-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bpf,core,feeder,monitor): improve performance and owner only handling #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
force-pushed
the
enhance-owneronly
branch
from
November 1, 2023 19:08
01a63bc
to
eb50feb
Compare
TODO: Remove CRI Storage mounts from deploygen and Operator. |
daemon1024
force-pushed
the
enhance-owneronly
branch
2 times, most recently
from
November 1, 2023 19:54
58bbf4b
to
94e71bc
Compare
Ankurk99
reviewed
Nov 3, 2023
daemon1024
force-pushed
the
enhance-owneronly
branch
2 times, most recently
from
November 8, 2023 13:44
61481f4
to
23d83aa
Compare
daemon1024
changed the title
feat(bpf,core,feeder): improve owner only handling
feat(bpf,core,feeder,monitor): improve performance and owner only handling
Nov 9, 2023
daemon1024
force-pushed
the
enhance-owneronly
branch
2 times, most recently
from
November 10, 2023 13:29
6873eb3
to
2fc54a5
Compare
We leveraged CRI Storage mounts to stat owner information from container fs, now we extract that information from eBPF eliminating the need of reading/mounting containerfs Signed-off-by: daemon1024 <barun1024@gmail.com>
…loops Signed-off-by: daemon1024 <barun1024@gmail.com>
Signed-off-by: daemon1024 <barun1024@gmail.com>
daemon1024
force-pushed
the
enhance-owneronly
branch
from
November 10, 2023 13:31
2fc54a5
to
d214bd2
Compare
nyrahul
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ankurk99
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We leveraged CRI Storage mounts to stat owner information from container fs, now we extract that information from eBPF eliminating the need of reading/mounting containerfs
Purpose of PR?:
Fixes #1178
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
CI Pass will validate this
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>