Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove CRI Storage volume and volume mounts #1507

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

anurag-rajawat
Copy link
Contributor

@anurag-rajawat anurag-rajawat commented Nov 14, 2023

Purpose of PR?:
Since we removed the CRI storage dependency in PR this PR is follow-up, removing the CRI storage volume and mounts from deploygen and operator.

Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@anurag-rajawat anurag-rajawat force-pushed the rm-cri-storage branch 2 times, most recently from 16a131a to 5a63566 Compare November 14, 2023 17:28
@anurag-rajawat anurag-rajawat marked this pull request as ready for review November 14, 2023 17:58
@anurag-rajawat anurag-rajawat marked this pull request as draft November 14, 2023 18:24
@anurag-rajawat anurag-rajawat marked this pull request as ready for review November 15, 2023 05:09
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Love the cleanup. Thanks

@anurag-rajawat anurag-rajawat force-pushed the rm-cri-storage branch 2 times, most recently from 51a9c03 to 5a8dbe3 Compare November 16, 2023 07:52
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@daemon1024 daemon1024 merged commit e3cadec into kubearmor:main Nov 22, 2023
18 checks passed
@anurag-rajawat anurag-rajawat deleted the rm-cri-storage branch November 22, 2023 15:36
PrimalPimmy pushed a commit to DelusionalOptimist/KubeArmor that referenced this pull request Jan 16, 2024
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants