Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubearmor policies are not getting enforced on reboot #631

Merged
merged 11 commits into from
Mar 7, 2022
Merged

Kubearmor policies are not getting enforced on reboot #631

merged 11 commits into from
Mar 7, 2022

Conversation

seswarrajan
Copy link
Contributor

Signed-off-by: Eswar Rajan Subramanian eswar@accuknox.com

Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
@seswarrajan seswarrajan marked this pull request as draft February 28, 2022 11:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #631 (0f04816) into main (005cdeb) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   43.74%   43.52%   -0.23%     
==========================================
  Files          23       23              
  Lines        8463     8504      +41     
==========================================
- Hits         3702     3701       -1     
- Misses       4313     4354      +41     
- Partials      448      449       +1     
Impacted Files Coverage Δ
KubeArmor/config/config.go 83.90% <ø> (ø)
KubeArmor/core/kubeArmor.go 53.10% <0.00%> (-0.74%) ⬇️
KubeArmor/core/kubeUpdate.go 44.78% <0.00%> (-1.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005cdeb...0f04816. Read the comment docs.

Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
seswarrajan and others added 4 commits March 3, 2022 14:42
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
@seswarrajan seswarrajan marked this pull request as ready for review March 4, 2022 04:59
@nyrahul nyrahul requested a review from daemon1024 March 4, 2022 10:50
KubeArmor/core/kubeUpdate.go Outdated Show resolved Hide resolved
KubeArmor/core/kubeUpdate.go Outdated Show resolved Hide resolved
KubeArmor/core/kubeUpdate.go Show resolved Hide resolved
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit. Rest LGTM. Can we squash the commits as well?

KubeArmor/core/kubeUpdate.go Outdated Show resolved Hide resolved
Signed-off-by: Eswar Rajan Subramanian <eswar@accuknox.com>
@daemon1024
Copy link
Member

LGTM, let's squash the commits and we are good to merge it then 👌

@seswarrajan
Copy link
Contributor Author

Hi @daemon1024
Once approved, we can squash and merge.

@seswarrajan seswarrajan linked an issue Mar 7, 2022 that may be closed by this pull request
@seswarrajan seswarrajan merged commit 86954a6 into kubearmor:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

policy enforcement issue when kubearmor is restarted in systemd mode
4 participants