Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated error message for failing to find pods before port forward #245

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

TheRealSibasishBehera
Copy link
Contributor

@TheRealSibasishBehera TheRealSibasishBehera commented Jan 18, 2023

Signed-off-by: sibashi fangedhamster3114@gmail.com

  • while doing port-forward , if pod is not found , the error message is always
    Error: kubearmor pod not found

Now the new error message also specifies the pod that was supposed to be found
For example in case of karmor summary if the client fails to find to find the pod

Error: kubearmor discovery-engine pod not found

@TheRealSibasishBehera TheRealSibasishBehera marked this pull request as ready for review January 18, 2023 19:32
Signed-off-by: sibashi <fangedhamster3114@gmail.com>
@TheRealSibasishBehera TheRealSibasishBehera changed the title update error message for failing to find discovery-engine pod updated error message for failing to find pods before port forward Jan 20, 2023
@nyrahul nyrahul self-requested a review January 24, 2023 07:32
discover/discover.go Outdated Show resolved Hide resolved
utils/portforward.go Outdated Show resolved Hide resolved
utils/portforward.go Outdated Show resolved Hide resolved
utils/portforward.go Outdated Show resolved Hide resolved
Signed-off-by: sibashi <fangedhamster3114@gmail.com>
@nyrahul nyrahul merged commit 4dca574 into kubearmor:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants