-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example/Docs: Removed env from collector-k8-manifest & updated tutori… #11
Conversation
1559596
to
e8b8f5b
Compare
Hey @Chinwendu20 I missed the ping you sent earlier on the linked issue : ( |
Worked in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Chinwendu20 Looking mostly good, just some minor points to address/discuss : )
Signed-off-by: Maureen Ononiwu <amaka013@gmail.com>
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
Thanks @Chinwendu20!
Thanks a lot. Could you please take a look at this PR as well? https://github.com/kubearmor/otel-adapter/pull/12/files |
This pull request address this issue: #8
The CRD definition Spec.env is only used to update environment variable in the container and not in spec. Config where the collector's configuration resides. I updated the docs to include how the configuration options available for the receiver.