example/Docs: Removed env from collector-k8-manifest & updated tutori… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chinwendu20
force-pushed
the
env
branch
2 times, most recently
from
1559596
to
e8b8f5b
Compare
|
Hey @Chinwendu20 I missed the ping you sent earlier on the linked issue : ( |
|
Worked in the PR. |
There was a problem hiding this comment.
@Chinwendu20 Looking mostly good, just some minor points to address/discuss : )
Signed-off-by: Maureen Ononiwu <amaka013@gmail.com>
|
Updated. |
DelusionalOptimist
approved these changes
Sep 7, 2023
|
Thanks a lot. Could you please take a look at this PR as well? https://github.com/kubearmor/otel-adapter/pull/12/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request address this issue: #8
The CRD definition Spec.env is only used to update environment variable in the container and not in spec. Config where the collector's configuration resides. I updated the docs to include how the configuration options available for the receiver.