Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UpdateStrategy Passthrough on Network Costs #1196

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

mbolt35
Copy link
Contributor

@mbolt35 mbolt35 commented Jan 6, 2022

What does this PR change?

This should handle the cases where the updateStrategy and all specific parameters can be passed via the values.yaml

How does this PR impact users? (This is the kind of thing that goes in release notes!)

  • Allow the Network Costs updateStrategy to be set via values.yaml

Links to Issues or ZD tickets this PR addresses or fixes

How was this PR tested?

Verified using helm template with networkCosts enabled:

# Source: cost-analyzer/templates/cost-analyzer-network-costs-template.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: kubecost-network-costs
  labels:
    app.kubernetes.io/name: cost-analyzer
    helm.sh/chart: cost-analyzer-1.89.0-rc.0
    app.kubernetes.io/instance: kubecost
    app.kubernetes.io/managed-by: Helm
    app: cost-analyzer
spec:
  updateStrategy:
    type: RollingUpdate
  selector:
    matchLabels:
      app: kubecost-network-costs
  template:
    metadata:
      labels:
        app: kubecost-network-costs
    spec:
      hostNetwork: true
      serviceAccountName: kubecost-cost-analyzer

This should handle the cases where the updateStrategy and all specific parameters can be passed via the values.yaml
@mbolt35 mbolt35 self-assigned this Jan 6, 2022
@mbolt35 mbolt35 added the enhancement New feature or request label Jan 6, 2022
@dwbrown2
Copy link
Contributor

@mbolt35 anything else needed on this PR before merging?

@pierluigilenoci
Copy link

@mbolt35 could you please take a look?

@mbolt35 mbolt35 merged commit bf769e8 into develop Feb 8, 2022
@mbolt35 mbolt35 deleted the bolt/network-costs-update-strategy branch February 8, 2022 04:31
@ivankube
Copy link
Contributor

ivankube commented Mar 3, 2022

fixed #1195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants