-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit mode with default true #21
Conversation
…ling eligible debug log message
3006b59
to
ea623f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please copy that logged output in audit mode as a code block, not screenshot? We should add this to the README.
Done |
27e570a
to
3faafa2
Compare
3faafa2
to
849857d
Compare
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
Co-authored-by: Chip Zoller <chipzoller@gmail.com>
@avrodrigues5 please review latest README changes. |
Really cool! Just a future idea, could be nice to show % savings and maybe even a total expected savings amount. |
What does this PR change?
Does this PR rely on any other PRs?
None
How does this PR impact users?
Default will be audit mode, unless it set to false the Disk auto scaling wouldnt perform any scaling up and scaling down operations
Links to Issues or tickets this PR addresses or fixes
closes #4
What risks are associated with merging this PR? What is required to fully test this PR?
The audit mode is a safe option as default so its better for user
How was this PR tested?
When run in audit mode logs will look like below
Without audit mode tested for scale up and scale down operation