reorganize the edgemesh project catalog #19

Poorunga · 2021-07-12T06:56:30Z

edgemesh will later have two parts: edgemesh-server and edgemesh-agent.
edgemesh-server is usually deployed in the cloud and acts as a relay server in the LibP2P mode or assist the agent to establish p2p hole punching. It is specifically responsible for forwarding data across subnets.
edgemesh-agent is usually deployed in the edge to act as an agent for communication between pods at different locations. It is internally divided into the following modules:

DNS: Built-in DNS resolver, which resolves the DNS request in the node into a service cluster IP.
proxy: Responsible for configuring the kernel's iptables rules, and intercepting requests to the EdgeMesh process.
gateway: gateway provides a ability to access services in external edge nodes.

Poorunga · 2021-07-13T06:12:40Z

/assign @Poorunga

khalid-huang · 2021-07-12T08:14:40Z

Makefile

@@ -111,10 +115,10 @@ clean:
 endif


+ARCH ?= amd64


where is this parameter used

Maybe it will be used in the future :)

I think this belong to useless code and will cause confusion to others.

khalid-huang · 2021-07-14T01:54:23Z

agent/cmd/edgemesh-agent/agent.go

 )

 func main() {
-	command := app.NewEdgeMeshCommand()
+	rand.Seed(time.Now().UnixNano())


where is this rand used

Maybe it will be used in the future :)

khalid-huang · 2021-07-14T02:07:34Z

agent/pkg/common/chassis/controller/controller.go

+		AddFunc: c.drAdd, UpdateFunc: c.drUpdate, DeleteFunc: c.drDelete})
+}
+
+//func (c *controller) epAdd(obj interface{})    {}


please delete useless code

khalid-huang · 2021-07-14T02:58:13Z

agent/pkg/gateway/manager/manager.go

 )

 // Manager is gateway manager
 type Manager struct {
+	ipArray          []net.IP
 	lock             sync.RWMutex


It seems that sync.Mutex is enough

khalid-huang · 2021-07-14T03:02:14Z

agent/pkg/gateway/manager/manager.go

+// UpdateGateway update a gateway server
+func (mgr *Manager) UpdateGateway(gw *istioapi.Gateway) {
+	mgr.lock.Lock()
+	defer mgr.lock.Unlock()


why do we need to lock the total function ? can we just lock the mgr.serversByGateway[key] = newGatewayServers

AddGateway can be modified as you said, but UpdaeGateway have multiple critical sections.

khalid-huang · 2021-07-19T01:51:01Z

/lgtm

ZBoIsHere · 2021-07-19T02:45:00Z

agent/pkg/proxy/controller/controller.go

+	Init()
+	GetSvcPorts(ip string) string
+	GetSvcIP(svcName string) string
+}


Why here need a set of interface, this interface only have one implement. in other module like dns, I found the similar code

Adopt your suggestion

ZBoIsHere · 2021-07-19T02:51:39Z

agent/pkg/proxy/proxy.go

-	svcPorts += svcName
-	return svcPorts
-}
+const SoOriginalDst = 80


constants puts on the front of file looks better

Yes, it's more standardized like that

ZBoIsHere · 2021-07-19T03:00:36Z

agent/pkg/common/modules/modules.go

+const (
+	EdgeDNSModuleName     = "edgedns"
+	EdgeProxyModuleName   = "edgeproxy"
+	EdgeGatewayModuleName = "edgegateway"


ModuleName and ModuleGroupName are better defined as two constants even if the two values are the same.

I think we can modify it later when necessary

ZBoIsHere · 2021-07-19T03:25:18Z

agent/pkg/proxy/module.go

+	proxy = &EdgeProxy{Config: c}
+	if !proxy.Config.Enable {
+		return proxy, nil
+	}


if !c.Enable { return } proxy = &EdgeProxy{Config: c}

judge {enable} in the front of function avoid creating EdgeProxy

It should be coded like this:

proxy = &EdgeProxy{Config: c} if !c.Enable { return proxy, nil }

Otherwise, registryModules will terminate as an error.

ZBoIsHere · 2021-07-19T06:40:12Z

agent/cmd/edgemesh-agent/app/config/config.go

+				Enable:          true,
+				ListenInterface: "docker0",
+				ListenPort:      53,
+			},


EdgeDNSConfig: dnsconfig.NewEdgeDNSConfig(), EdgePorxyConfig: proxyconfig.NewEdgeProxyConfig(),
every module have self default config function may be better

Adopt your suggestion

ZBoIsHere · 2021-07-20T08:12:49Z

agent/pkg/proxy/controller/controller.go

+}
+
+type controller struct {
+	svcLister   listers.ServiceLister


what's the usage of svcLister, I just find the initialization code

Alright, svcLister has been deleted.

ZBoIsHere · 2021-07-20T09:19:05Z

agent/pkg/proxy/controller/controller.go

+	IPBySvc      map[string]string // key: svcName.svcNamespace, value: clusterIP
+}
+
+func New(ifm *informers.Manager) *controller {


I think function New should return a singleton, if other package want to use the interface of controller, now have to import it in the package proxy, and new a proxy to call it.

Adopt your suggestion

ZBoIsHere · 2021-07-22T06:15:02Z

agent/pkg/proxy/controller/controller.go

+func (c *controller) GetSvcIP(svcName string) string {
+	c.RLock()
+	defer c.RUnlock()
+	ip := c.IPBySvc[svcName]


If controller is a singleton and you want user use function GetScvIP to get ClusterIP, then IPBySvc should be ipBySvc, SvcPortsByIP as the same

Adopt your suggestion

kubeedge-bot · 2021-07-23T02:00:27Z

@ZBoIsHere: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ZBoIsHere · 2021-07-23T02:03:00Z

/assign @ZBoIsHere

kubeedge-bot · 2021-07-23T02:16:07Z

@ZBoIsHere: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

llhuii · 2021-07-23T03:54:16Z

/lgtm

llhuii · 2021-07-23T03:58:11Z

/lgtm cancel

Signed-off-by: Poorunga <2744323@qq.com>

khalid-huang · 2021-07-23T06:18:06Z

/lgtm

fisherxu · 2021-07-23T06:48:53Z

/approve

kubeedge-bot · 2021-07-23T06:49:08Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: fisherxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Poorunga force-pushed the tidyup branch from 1ad6093 to 654201a Compare July 12, 2021 06:56

fisherxu closed this Jul 13, 2021

fisherxu reopened this Jul 13, 2021

kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 13, 2021

fisherxu requested a review from khalid-huang July 13, 2021 02:48

kubeedge-bot assigned Poorunga Jul 13, 2021

khalid-huang reviewed Jul 14, 2021

View reviewed changes

Poorunga force-pushed the tidyup branch from 654201a to b74cdb8 Compare July 16, 2021 02:12

kubeedge-bot assigned khalid-huang Jul 19, 2021

kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021

ZBoIsHere reviewed Jul 20, 2021

View reviewed changes

ZBoIsHere reviewed Jul 22, 2021

View reviewed changes

Poorunga force-pushed the tidyup branch from b74cdb8 to ae3df74 Compare July 22, 2021 14:42

kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021

kubeedge-bot assigned ZBoIsHere Jul 23, 2021

Poorunga force-pushed the tidyup branch from ae3df74 to 6bb289f Compare July 23, 2021 02:09

kubeedge-bot assigned llhuii Jul 23, 2021

kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021

kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021

llhuii removed their assignment Jul 23, 2021

Poorunga added 2 commits July 23, 2021 14:15

organize the edgemesh directory with dns, proxy, and gateway modules

8b6d0c8

Signed-off-by: Poorunga <2744323@qq.com>

remove old cmd and pkg directory

77152c3

Signed-off-by: Poorunga <2744323@qq.com>

update makefile, hack, build and ci files

1c3dba2

Signed-off-by: Poorunga <2744323@qq.com>

Poorunga force-pushed the tidyup branch from 6bb289f to 1c3dba2 Compare July 23, 2021 06:15

kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021

ZBoIsHere mentioned this pull request Jul 23, 2021

REQUEST: New membership for ZBoIsHere kubeedge/community#55

Closed

7 tasks

fisherxu added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021

kubeedge-bot merged commit 2522dbe into kubeedge:main Jul 23, 2021

Poorunga mentioned this pull request Nov 3, 2021

use hostResolve instead /etc/resolv.conf #28

Closed

Poorunga deleted the tidyup branch January 17, 2023 12:55

reorganize the edgemesh project catalog #19

reorganize the edgemesh project catalog #19

Conversation

Poorunga commented Jul 12, 2021 • edited Loading

Poorunga commented Jul 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Poorunga Jul 16, 2021 • edited Loading

Choose a reason for hiding this comment

khalid-huang commented Jul 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Poorunga Jul 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kubeedge-bot commented Jul 23, 2021

ZBoIsHere commented Jul 23, 2021

kubeedge-bot commented Jul 23, 2021

llhuii commented Jul 23, 2021

llhuii commented Jul 23, 2021

khalid-huang commented Jul 23, 2021

fisherxu commented Jul 23, 2021

kubeedge-bot commented Jul 23, 2021

Poorunga commented Jul 12, 2021 •

edited

Loading

Poorunga Jul 16, 2021 •

edited

Loading

Poorunga Jul 22, 2021 •

edited

Loading