use hostResolve instead /etc/resolv.conf #28
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @pengbinbin1! It looks like this is your first PR to kubeedge/edgemesh 🎉 |
kubeedge-bot
added
the
size/XS
agent/pkg/dns/dns.go
Outdated
| @@ -168,7 +168,7 @@ func (dns *EdgeDNS ) getFromRealDNS(req []byte, from *net.UDPAddr) { | |||
|
|
|||
| // parseNameServer gets all real nameservers from the resolv.conf | |||
| func (dns *EdgeDNS) parseNameServer() ([]net.IP, error) { | |||
| file, err := os.Open("/etc/resolv.conf") | |||
| file, err := os.Open(hostResolv) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("error opening /etc/resolv.conf: %v", err) | |||
There was a problem hiding this comment.
@pengbinbin1 /etc/resolv.conf in log should modified synchronously.
There was a problem hiding this comment.
log has been modified synchronously
Signed-off-by: pengbinbin1 <pengbiny@163.com>
kubeedge-bot
added
the
needs-rebase
|
@pengbinbin1: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pengbinbin1 needs rebase |
|
This issue has been resolved in PR #19 /close |
|
@Poorunga: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
i think a constant variable is better than string