Reliable message delivery design proposal #1343
Conversation
kubeedge-bot
requested review from
subpathdev,
cwl233,
kevin-wangzefeng,
rohitsardesai83,
sids-b and
kadisi
|
@fisherxu: GitHub didn't allow me to request PR reviews from the following users: du2016. Note that only kubeedge members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubeedge-bot
added
the
size/L
fisherxu
force-pushed
the
reliab-proposal
branch
from
55824ae
to
ad47a72
Compare
fisherxu
force-pushed
the
reliab-proposal
branch
from
ad47a72
to
e62b601
Compare
| - "@kadisi" | ||
| creation-date: 2019-12-23 | ||
| last-updated: 2019-12-23 | ||
| status: alpha |
There was a problem hiding this comment.
| status: alpha | |
| status: provisional |
|
Comment from community meeting:
|
fisherxu
force-pushed
the
reliab-proposal
branch
from
34a98dc
to
a724ce4
Compare
|
|
||
| - CloudHub will sequentially send data from the NodeMessageQueue to the corresponding edge node, | ||
| and will also store the message ID in an ACK channel. When the ACK message from the edge node received, | ||
| ACK channel will trigger to save the message resourceVersion to K8s as CRD, and send the next message. |
There was a problem hiding this comment.
about ack channel, I recommend using sync.Cond to implementation it.
There was a problem hiding this comment.
We have used the sync.Map now.
fisherxu
force-pushed
the
reliab-proposal
branch
2 times, most recently
from
96c599a
to
1a22073
Compare
fisherxu
force-pushed
the
reliab-proposal
branch
from
1a22073
to
9faed8b
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevin-wangzefeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
/lgtm |
What type of PR is this?
/kind design
What this PR does / why we need it:
Provide a reliable message delivery mechanism between cloud and edge.
Which issue(s) this PR fixes:
Fixes #725
Special notes for your reviewer:
/cc @kevin-wangzefeng @rohitsardesai83 @sids-b @kadisi @chendave @subpathdev @du2016 @cwl233
Does this PR introduce a user-facing change?: