Mapper proposal #2147
Mapper proposal #2147
Conversation
Reconstruct the mapper desgin.
kubeedge-bot
added
the
size/L
|
@kevin-wangzefeng @fisherxu let's discuss it in next community meeting |
docs/proposals/mapper-redesign.md
Outdated
| The original description could refer to the doc [mapper-design.md](https://github.com/kubeedge/kubeedge/blob/master/docs/proposals/mapper-design.md "mapper-design.md"). | ||
|
|
||
| Mapper is an interface between kubeedge and devices. It could set/get device data, get and report the device status. | ||
| Kubeedge uses device controller, device twin and mapper to control the devices. |
There was a problem hiding this comment.
| Kubeedge uses device controller, device twin and mapper to control the devices. | |
| KubeEdge uses device controller, device twin and mapper to control the devices. |
There was a problem hiding this comment.
Thanks for your review and time.
Done.
docs/proposals/mapper-redesign.md
Outdated
| approvers: | ||
| - "@" | ||
| - "@" | ||
| creation-date: 2020-09- |
There was a problem hiding this comment.
| approvers: | |
| - "@" | |
| - "@" | |
| creation-date: 2020-09- | |
| approvers: | |
| - "@kevin-wangzefeng" | |
| - "@" | |
| creation-date: 2020-09-09 |
docs/proposals/mapper-redesign.md
Outdated
| const DeviceStatus { | ||
| DEVSTOK | ||
| DEVSTERR /*Expected value is not equal as setting*/ | ||
| DEVSTDISCONN | ||
| DEVSTUNHEALTHY /*Unhealthy status from device*/ | ||
| } |
There was a problem hiding this comment.
Not quite understand the code here, what's the value type of the consts?
There was a problem hiding this comment.
Just want to present all status that reported to the device controller. In the code, the type is uint.
|
Minor comments, thanks |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevin-wangzefeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
/assign @fisherxu |
|
nit: maybe "mapper refactoring proposal" or "mapper design v2" is better for the proposal name |
|
@sailorvii Let's rename the proposal to "mapper design v2"？ |
What type of PR is this?
/kind design
What this PR does / why we need it:
Simplify the mapper structure
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
All mappers will be refined.