Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the code to remove redundant statements #493

Merged
merged 1 commit into from May 10, 2019
Merged

Refactor the code to remove redundant statements #493

merged 1 commit into from May 10, 2019

Conversation

chendave
Copy link
Member

Signed-off-by: Dave Chen dave.chen@arm.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind cleanup

@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 10, 2019
@chendave
Refactor the code to remove redundant statements
1e4b275 
Signed-off-by: Dave Chen <dave.chen@arm.com>
sids-b
sids-b approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@sids-b sids-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rohitsardesai83
rohitsardesai83 approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@rohitsardesai83 rohitsardesai83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rohitsardesai83 rohitsardesai83 merged commit 758c2a4 into kubeedge:master May 10, 2019
@chendave chendave deleted the refactor branch May 11, 2019 06:15
@rohitsardesai83 rohitsardesai83 mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitsardesai83 rohitsardesai83 rohitsardesai83 approved these changes

@sids-b sids-b sids-b approved these changes

Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chendave @rohitsardesai83 @sids-b @kubeedge-bot