Automated cherry pick of #493: Refactor the code to remove redundant statements

[rohitsardesai83]

Cherry pick of #493 on release-0.3.

#493: Refactor the code to remove redundant statements

[m1093782566]

Is this a bug fix or usage guide? If not, I would suggest move it to v1.0.

[rohitsardesai83]

Is this a bug fix or usage guide? If not, I would suggest move it to v1.0.

This is a code improvement needed for v0.3

[sids-b]

@m1093782566 , it is just removal of redundant code.

[sids-b]

/lgtm

[m1093782566]

@rohitsardesai83 @sids-b

I think you may misunderstand the criteria of cherry-pick. I think only bug fixes worth cherry-picking to a specific release branch - you can see Kubernetes for reference. If the code refactor is necessary for later cherry-picks, I can let it in but for now I don't see any.

cc @kevin-wangzefeng

[sids-b]

Actually it is code cleanup of the feature(deviceController) which was introduced in v0.3.0-beta.0.

[rohitsardesai83]

@rohitsardesai83 @sids-b

I think you may misunderstand the criteria of cherry-pick. I think only bug fixes worth cherry-picking to a specific release branch - you may refer to Kubernetes.

cc @kevin-wangzefeng

since the device controller was introduced as a part of 0.3 release , and this code doesn't introduce any new feature , it is a cleanup activity which I think should be ok to be cherry picked. Only thing is this activity was not associated with any issue. We should in such cases follow practice of always opening issues and then raise PRs.

[sids-b]

And also we are cherry picking for 0.3.0 which is a minor release and not a patch release. So i feel adding code cleanups , docs and CRD examples should be fine ?
Thoughts @kevin-wangzefeng @m1093782566 ?

[m1093782566]

it is a cleanup activity which I think should be ok to be cherry picked.

I think we need to set some barries for cherry-picks for decreasing the number of cherry-picks. Thoughts?

[m1093782566]

So i feel adding code cleanups , docs and CRD examples should be fine ?

Do you mean all?

[kevin-wangzefeng]

The release-xx branches only accepts imporntant bugfixes and document updates. New features, refactoring, clean-up, or fixes that changing functionalities behaviour should not be accepted.