Add onvif mapper based kubeedge v1.17.0 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubeedge-bot
added
the
size/XXL
wbc6080
force-pushed
the
add-onvif-mapper
branch
2 times, most recently
from
4715f91
to
73b6e63
Compare
wbc6080
changed the title
wbc6080
force-pushed
the
add-onvif-mapper
branch
from
f05d8b6
to
d634d38
Compare
|
/lgtm |
fisherxu
reviewed
May 7, 2024
fisherxu
reviewed
May 8, 2024
mappers/kubeedge-v1.17.0/onvif-mapper/data/dbmethod/redis/client.go
Outdated
Show resolved
Hide resolved
mappers/kubeedge-v1.17.0/onvif-mapper/data/dbmethod/tdengine/client.go
Outdated
Show resolved
Hide resolved
Signed-off-by: wbc6080 <wangbincheng4@huawei.com>
|
The code has been modified according to the comments @fisherxu. At the same time, since part of the code is generated by mapper-framework, I think mapper-framework still needs to be modified. I will submit a PR to the main repo later. |
fisherxu
reviewed
May 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add onvif mapper based mapper-framework in v1.17.0 of kubeedge