Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Destroy #744

Merged
merged 1 commit into from
Nov 17, 2022
Merged

feat: Improve Destroy #744

merged 1 commit into from
Nov 17, 2022

Conversation

marinhojess
Copy link
Contributor

Signed-off-by: Jessica Marinho jessica@kubeshop.io

Removing all resources from the VPC before deleting the remaining security group, an then try to delete VPC again.

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
Copy link
Contributor

@pagottoo pagottoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marinhojess marinhojess merged commit b4699d5 into main Nov 17, 2022
@marinhojess marinhojess deleted the improve-destroy branch November 17, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants