address nginx load balancer and sg removal during deprovision #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndietz
changed the title
jarededwards
approved these changes
Dec 6, 2022
converge
pushed a commit
that referenced
this pull request
Dec 8, 2022
* add CODEOWNERS & assign myself to the docs * simplify the SVG file + add light theme logo (#787) Signed-off-by: Frédéric Harper <fred@kubeshop.io> * fix: destroy elb (#803) * fix: #804 Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * add contrast to links (provided by @donnalux) Signed-off-by: Frédéric Harper <hi@fred.dev> * Update install.md (#810) * fix Google Analytics Signed-off-by: Frédéric Harper <hi@fred.dev> * remove dedicated graviton page (#821) * address nginx load balancer and sg removal during deprovision (#815) * removing duplicate port forward to minio * fix kubefirst local connect output * removing nginx loadbalancer during destroy * removing old lb/sg removal process * adjusting gitops nginx removal to fresh clone * remove branch mgmt from private clone * latest round of orchestration * providing nginx deprovisioning more time to clean up cloud resources Signed-off-by: João Vanzuita <joao@kubeshop.io> * fix: use portforward address for cloud console Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: Frédéric Harper <fred@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> Co-authored-by: Frédéric Harper <fred@kubeshop.io> Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com> Co-authored-by: John Dietz <john@kubefirst.com>
pagottoo
added a commit
that referenced
this pull request
Dec 14, 2022
* Feat add ingress rules fork (#790) * feat: add generic function for secret creation * chore: add tests * feat: open 443 port mapping for k3d load balancer * refactor: initial argocd config, split it into local and cloud * 746 spike https local (#773) * calling methods to create certs on local * added mkcert stuffs on config struct * downloading mkcert * added func to install CA and make certs * feat: add generic create certificate function * chore: move secret creation for end of installation * chore: use correct key names for certificate secrets * feat: add download in parallel for local * feat: Add argocd ingress route (#776) - Add argocd ingress route to allow traefik use a different certificate * chore: update argo config yaml * feat: add integration test for TLS on localdev.me * feat: remove port forwards (except atlantis), use ingress * feat: disable port forwards for local destroy * feat: make use of ingress rules instead of port forward for local connect * feat: console link updates * feat: Detokenize ngrok (#784) * temporary PR to enable atlantis port forward until the final solution (#793) * feat: Detokenize ngrok Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: Thiago Pagotto <pagottoo@gmail.com> Signed-off-by: Jessica Marinho <jessica@kubeshop.io> Co-authored-by: CristhianF7 <CristhianF7@gmail.com> * refactor: improve template download logic (#791) * refactor: improve template download logic (for local only) Signed-off-by: João Vanzuita <joao@kubeshop.io> * feat_atlantis_ngrok_traefik_ssl (#799) * remove atlantis url param * adjust detokenize url/host ngrok values * remove unused dest param and handle the tunnel on http/80 port Signed-off-by: Thiago Pagotto <pagottoo@gmail.com> Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io> * Feat introduce log levels fork (#792) * feat: introduce log levels Signed-off-by: João Vanzuita <joao@kubeshop.io> * Fix: #818 (#822) Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * feat: skip metaphor #813 (#819) Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * feat: add redirect to https from ingress (#825) Signed-off-by: Jessica Marinho <jessica@kubeshop.io> Signed-off-by: Jessica Marinho <jessica@kubeshop.io> * feat: Add ingress endpoints to handoff screen (#827) Signed-off-by: Jessica Marinho <jessica@kubeshop.io> Signed-off-by: Jessica Marinho <jessica@kubeshop.io> * chore: use constants for urls (#829) * chore: use constants for urls Signed-off-by: João Vanzuita <joao@kubeshop.io> * Refactor improve local destroy (#828) * feat: add redirect to https from ingress * chore: initial changes for local destroy * feat: add force destroy for local Signed-off-by: João Vanzuita <joao@kubeshop.io> Co-authored-by: Jessica Marinho <jessica@kubeshop.io> * Update logs (#830) * chore: logs update to use zerolog * chore: update log messages * chore: update log messages from error to warning Signed-off-by: João Vanzuita <joao@kubeshop.io> * feat: adding new detokenize params for telemetry (#834) * Fix telemetry unit test (#833) * fix: unit test for telemetry * fix: malformed log messages * chore: keep panic instead of error * fix: add workaround to make machine id library works in container * chore: remove outdated comment Signed-off-by: João Vanzuita <joao@kubeshop.io> * Merge main into 1.11 release (#835) * add CODEOWNERS & assign myself to the docs * simplify the SVG file + add light theme logo (#787) Signed-off-by: Frédéric Harper <fred@kubeshop.io> * fix: destroy elb (#803) * fix: #804 Signed-off-by: 6za <53096417+6za@users.noreply.github.com> * add contrast to links (provided by @donnalux) Signed-off-by: Frédéric Harper <hi@fred.dev> * Update install.md (#810) * fix Google Analytics Signed-off-by: Frédéric Harper <hi@fred.dev> * remove dedicated graviton page (#821) * address nginx load balancer and sg removal during deprovision (#815) * removing duplicate port forward to minio * fix kubefirst local connect output * removing nginx loadbalancer during destroy * removing old lb/sg removal process * adjusting gitops nginx removal to fresh clone * remove branch mgmt from private clone * latest round of orchestration * providing nginx deprovisioning more time to clean up cloud resources Signed-off-by: João Vanzuita <joao@kubeshop.io> * fix: use portforward address for cloud console Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: Frédéric Harper <fred@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> Co-authored-by: Frédéric Harper <fred@kubeshop.io> Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com> Co-authored-by: John Dietz <john@kubefirst.com> * chore: clean up Signed-off-by: João Vanzuita <joao@kubeshop.io> * feat: lowercase user (#837) * chore: fix log message (#865) Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> * fix: provide better documentation for use-telemetry flag (#877) Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> * fix: lowercase github owner (#878) * fix: rm logs flag for clean command (#881) Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> * Fix argocd initial file refactor and vault retry logic (#847) * fix: malformed yaml file for initial argocd * refactor: waiting for vault functionality * chore: update argo config struct Signed-off-by: João Vanzuita <joao@kubeshop.io> * Implement segmentio identify (#743) * feat: implement segmentio identify * docs: update in code documentation for segmentio identify Signed-off-by: João Vanzuita <joao@kubeshop.io> * Sync with main (#888) * draft: docs for kubefirst local (#823) * removing duplicate port forward to minio * fix kubefirst local connect output * removing nginx loadbalancer during destroy * removing old lb/sg removal process * adjusting gitops nginx removal to fresh clone * remove branch mgmt from private clone * latest round of orchestration * local docs starting point * adding kubefirst local docs * Update docs/index.md Co-authored-by: Jared Edwards <jared@kubefirst.com> Co-authored-by: Jared Edwards <jared@kubefirst.com> * orchestrating ingress-nginx removal (#860) * Update index.md (#862) * create an issue template form for the documentations Signed-off-by: Frédéric Harper <hi@fred.dev> * fix the documentation test & publication process (#806) Signed-off-by: Frédéric Harper <hi@fred.dev> Co-authored-by: John Dietz <john@kubefirst.com> Co-authored-by: Jared Edwards <jared@kubefirst.com> Co-authored-by: Frédéric Harper <hi@fred.dev> Co-authored-by: Frédéric Harper <fred@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: Thiago Pagotto <pagottoo@gmail.com> Signed-off-by: Jessica Marinho <jessica@kubeshop.io> Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Signed-off-by: Frédéric Harper <fred@kubeshop.io> Signed-off-by: Frédéric Harper <hi@fred.dev> Co-authored-by: CristhianF7 <CristhianF7@gmail.com> Co-authored-by: Thiago Pagotto <pagottoo@gmail.com> Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com> Co-authored-by: Jéssica Marinho <jessica@kubeshop.io> Co-authored-by: Frédéric Harper <fred@kubeshop.io> Co-authored-by: John Dietz <john@kubefirst.com> Co-authored-by: Jared Edwards <jared@kubefirst.com> Co-authored-by: Frédéric Harper <hi@fred.dev>
fharper
pushed a commit
that referenced
this pull request
Dec 19, 2022
- 746 spike https local (#773) - add argocd ingress route to allow traefik use a different certificate - add CODEOWNERS & assign myself to the docs - add contrast to links (provided by @donnalux) - add func to install CA and make certs - add kubefirst local docs - add mkcert stuffs on config struct - address nginx load balancer and sg removal during deprovision (#815) - adjust detokenize url/host ngrok values - adjust gitops nginx removal to fresh clone - adjust gitops nginx removal to fresh clone - call methods to create certs on local - chore: add tests - chore: clean up - chore: fix log message (#865) - chore: initial changes for local destroy - chore: keep panic instead of error - chore: logs update to use zerolog - chore: move secret creation for end of installation - chore: remove outdated comment - chore: update argo config struct - chore: update argo config yaml - chore: update log messages - chore: update log messages from error to warning - chore: use constants for urls - chore: use constants for urls (#829) - chore: use correct key names for certificate secrets - create an issue template form for the documentations - docs: update in code documentation for segmentio identify - downloading mkcert - draft: docs for kubefirst local (#823) - feat: Add argocd ingress route (#776) - feat: add download in parallel for local - feat: add force destroy for local - feat: add generic create certificate function - feat: add generic function for secret creation - feat: Add ingress endpoints to handoff screen (#827) - feat: add ingress rules fork (#790) - feat: add integration test for TLS on localdev.me - feat: add redirect to https from ingress - feat: add redirect to https from ingress (#825) - feat: adding new detokenize params for telemetry (#834) - feat: console link updates - feat: Detokenize ngrok - feat: Detokenize ngrok (#784) - feat: disable port forwards for local destroy - feat: feat_atlantis_ngrok_traefik_ssl (#799) - feat: implement segmentio identify - feat: introduce log levels - feat: introduce log levels fork (#792) - feat: lowercase user (#837) - feat: make use of ingress rules instead of port forward for local connect - feat: open 443 port mapping for k3d load balancer - feat: remove port forwards (except atlantis), use ingress - feat: skip metaphor #813 (#819) - fix: #804 - fix: #818 (#822) - fix: add workaround to make machine id library works in container - fix: argocd initial file refactor and vault retry logic (#847) - fix: destroy elb (#803) - fix: Google Analytics - fix: kubefirst local connect output - fix: kubefirst local connect output - fix: lowercase github owner (#878) - fix: malformed log messages - fix: malformed yaml file for initial argocd - fix: provide better documentation for use-telemetry flag (#877) - fix: rm logs flag for clean command (#881) - fix: telemetry unit test (#833) - fix: the documentation test & publication process (#806) - fix: unit test for telemetry - fix: use portforward address for cloud console - implement segmentio identify (#743) - latest round of orchestration - latest round of orchestration - local docs starting point - orchestrating ingress-nginx removal (#860) - providing nginx deprovisioning more time to clean up cloud resources - refactor improve local destroy (#828) - refactor: improve template download logic (#791) - refactor: improve template download logic (for local only) - refactor: initial argocd config, split it into local and cloud - refactor: waiting for vault functionality - remove atlantis url param - remove branch mgmt from private clone - remove branch mgmt from private clone - remove dedicated graviton page (#821) - remove unused dest param and handle the tunnel on http/80 port - removing duplicate port forward to minio - removing duplicate port forward to minio - removing nginx loadbalancer during destroy - removing nginx loadbalancer during destroy - removing old lb/sg removal process - removing old lb/sg removal process - simplify the SVG file + add light theme logo (#787) - temporary PR to enable atlantis port forward until the final solution (#793) - Update docs/index.md - Update index.md (#862) - Update install.md (#810) - Update logs (#830) Signed-off-by: 6za <53096417+6za@users.noreply.github.com> Signed-off-by: Frédéric Harper <fred@kubeshop.io> Signed-off-by: Jessica Marinho <jessica@kubeshop.io> Signed-off-by: João Vanzuita <joao@kubeshop.io> Signed-off-by: Thiago Pagotto <pagottoo@gmail.com> Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com> Co-authored-by: CristhianF7 <CristhianF7@gmail.com> Co-authored-by: Frédéric Harper <fred@kubeshop.io> Co-authored-by: Jared Edwards <jared@kubefirst.com> Co-authored-by: Jessica Marinho <jessica@kubeshop.io> Co-authored-by: João Paulo Vanzuita <joao@kubeshop.io> Co-authored-by: John Dietz <john@kubefirst.com> Co-authored-by: Thiago Pagotto <pagottoo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.