Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include env var for region #944

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix: Include env var for region #944

merged 1 commit into from
Dec 16, 2022

Conversation

marinhojess
Copy link
Contributor

Terraform provider needs to know which region to use to authenticate to AWS, if the region doesn't exist in the AWS shared file, it must be informed in another way.

An alternative is to include the region informed by the installer flag as an AWS_REGION environment variable, on this way terraform provider will be able to identify the correct version through the flag.

Signed-off-by: Jessica Marinho jessica@kubeshop.io

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
@marinhojess marinhojess added the bug Something isn't working label Dec 16, 2022
@marinhojess marinhojess added this to the 1.11 Release milestone Dec 16, 2022
@marinhojess marinhojess self-assigned this Dec 16, 2022
@marinhojess marinhojess linked an issue Dec 16, 2022 that may be closed by this pull request
Copy link
Contributor

@pagottoo pagottoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marinhojess marinhojess merged commit 33db283 into main Dec 16, 2022
@marinhojess marinhojess deleted the fix-region-terraform branch December 16, 2022 17:13
fharper pushed a commit that referenced this pull request Dec 19, 2022
Signed-off-by: Jessica Marinho <jessica@kubeshop.io>

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
fharper pushed a commit that referenced this pull request Dec 21, 2022
Signed-off-by: Jessica Marinho <jessica@kubeshop.io>

Signed-off-by: Jessica Marinho <jessica@kubeshop.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS - Github Terraform not following install Region
2 participants