Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xieydd and pineking as member #217

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

xieydd
Copy link
Member

@xieydd xieydd commented Dec 3, 2018

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @xieydd. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xieydd
Copy link
Member Author

xieydd commented Dec 5, 2018

/cc @jlewi

@xieydd
Copy link
Member Author

xieydd commented Dec 6, 2018

@jlewi pls help to review this PR, thx.

@jlewi
Copy link
Contributor

jlewi commented Dec 6, 2018

https://devstats.kubeflow.org/d/13/developers-table?orgId=1

xieydd 14 Prs

Looks like pineking has been very active in discussions on GitHub issues
https://github.com/issues?q=org%3Akubeflow+pineking+is%3Aclosed

Thank you both very much for your contributions.

/lgtm
/approve

@jlewi
Copy link
Contributor

jlewi commented Dec 6, 2018

Please submit a PR to
Adding yourself as members so we can send you an invite to own the org.
https://github.com/kubeflow/internal-acls/blob/master/github-orgs/kubeflow/org.yaml

@xieydd
Copy link
Member Author

xieydd commented Dec 7, 2018

@jlewi Done, pls help to review this PR.

@jlewi
Copy link
Contributor

jlewi commented Dec 7, 2018

/lgtm
/approve
/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ffefb9d into kubeflow:master Dec 7, 2018
@xieydd
Copy link
Member Author

xieydd commented Dec 9, 2018

@jlewi . I notice the PR is merged, but i did`t receive the inventation of the org. 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants