Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error, field names, type_check=False #965

Closed
wants to merge 1 commit into from

Conversation

ma08
Copy link

@ma08 ma08 commented Jun 16, 2022

  • Fix missing ' leading to syntax error
  • Fix field names by replacing '-' with '_'
  • Add type_check=False to fix error (GCSPath - String mismatch)

I had to make the above changes to get the pipeline running.

Fix missing ' leading to syntax error
Fix field names by replacing '-' with '_'
Add type_check=False  to fix error (GCSPath - String mismatch)
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla
Copy link

google-cla bot commented Jun 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ma08
To complete the pull request process, please assign jinchihe after the PR has been reviewed.
You can assign the PR to them by writing /assign @jinchihe in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from jinchihe and js-ts June 16, 2022 09:01
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ma08
Copy link
Author

ma08 commented Sep 22, 2022

/assign @jinchihe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants