Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Make fairing as a subpackage in kubeflow #359

Merged
merged 1 commit into from Sep 12, 2019

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Aug 30, 2019

What this PR does / why we need it:

Make fairing as a subpackage in kubeflow, see more in #234

After the PR, fairing will be a subpackage in kubeflow. and the changes are as following:

  1. Created new kubeflow foler, and moved fairing and containerregistry to kubeflow.
  2. Updated some imports to from kubeflow import fairing and import kubeflow.fairing.

For the kubeflow python sdk, user can install by

pip install kubeflow-fairing

Which issue(s) this PR fixes:
Fixes #234

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Fairing is a subpackage in `kubeflow`.

This change is Reviewable

@jinchihe jinchihe force-pushed the update_to_kubeflow_fairing branch 3 times, most recently from 9c41bf9 to f141013 Compare August 31, 2019 02:00
@jinchihe jinchihe force-pushed the update_to_kubeflow_fairing branch 18 times, most recently from 2fc55d2 to 025e910 Compare September 2, 2019 08:22
@jinchihe jinchihe changed the title WIP: make fairing as a subpackage in kubeflow Make fairing as a subpackage in kubeflow Sep 2, 2019
@jinchihe
Copy link
Member Author

jinchihe commented Sep 2, 2019

Hello @jlewi @abhi-g @karthikv2k , the PR is ready for reviewing, thanks a lot!

@jinchihe
Copy link
Member Author

jinchihe commented Sep 4, 2019

/assign @jlewi
/assign @abhi-g

Could you please help to review? Thanks a lot!

@jlewi
Copy link
Contributor

jlewi commented Sep 5, 2019

Would a user really do pip install kubeflow? Or does it depend on how we upload this to the pip repository?

Copy link
Contributor

@jlewi jlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 167 files reviewed, 1 unresolved discussion (waiting on @abhi-g, @jinchihe, and @karthikv2k)


setup.py, line 7 at r1 (raw file):

setuptools.setup(
    name='kubeflow',

how about kubeflow-fairing so that its a sub package install?
See comment in #234 Do we need to create an Uber Kubeflow package right now?
If we do need an Uber package can we do that at release time by combining all the sub packages.

@jlewi
Copy link
Contributor

jlewi commented Sep 5, 2019

One minor comment on my end; it looks like setup.py is naming the package to "kubeflow" per my comments in #234 I prefer to keep the pip package named such that it reflects the fact that fairing is just one subpackage.

Could we change it to something like

pip install kubeflow-fairing

@jinchihe jinchihe force-pushed the update_to_kubeflow_fairing branch 2 times, most recently from d0d1eac to 42ca0ec Compare September 11, 2019 08:08
@jinchihe
Copy link
Member Author

Hello @jlewi @abhi-g

Addressed your comments, updated the PR using pkgutil-style namespace packages which supports Python 2. See more discussion with @jlewi in #234 For now the Fairing is kubefloe subpacakge, and user can install kubeflow-fairing by:

pip install kubeflow-fairing

Ready for checking in, please view. thanks!

@jlewi
Copy link
Contributor

jlewi commented Sep 11, 2019

Whoo Hooo!
/lgtm
/approve
/hold

@jinchihe Can you open issues to update the examples and docs? They should probably be P0 and filed under project 0.7.

I think we should probably get the xgboost_synthetic example updated at a minimum.

You can remove the hold. I just wanted you to see this comment and file the issues. Thanks

@jinchihe
Copy link
Member Author

@jlewi Yes, already logged ticket in examples kubeflow/examples#636 and doc kubeflow/website#1146, and assigned to me, will update very soon.

/hold cancel

@jinchihe
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinchihe, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c5be73f into kubeflow:master Sep 12, 2019
@jinchihe jinchihe deleted the update_to_kubeflow_fairing branch September 12, 2019 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out python packaging for fairing
4 participants