Make fairing as a subpackage in kubeflow #359
Make fairing as a subpackage in kubeflow #359
Conversation
347535c
to
5ec4f1d
Compare
9c41bf9
to
f141013
Compare
2fc55d2
to
025e910
Compare
Hello @jlewi @abhi-g @karthikv2k , the PR is ready for reviewing, thanks a lot! |
025e910
to
a4d7899
Compare
Would a user really do pip install kubeflow? Or does it depend on how we upload this to the pip repository? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 167 files reviewed, 1 unresolved discussion (waiting on @abhi-g, @jinchihe, and @karthikv2k)
setup.py, line 7 at r1 (raw file):
setuptools.setup( name='kubeflow',
how about kubeflow-fairing so that its a sub package install?
See comment in #234 Do we need to create an Uber Kubeflow package right now?
If we do need an Uber package can we do that at release time by combining all the sub packages.
One minor comment on my end; it looks like setup.py is naming the package to "kubeflow" per my comments in #234 I prefer to keep the pip package named such that it reflects the fact that fairing is just one subpackage. Could we change it to something like
|
d0d1eac
to
42ca0ec
Compare
42ca0ec
to
6a78d5e
Compare
Addressed your comments, updated the PR using pkgutil-style namespace packages which supports Python 2. See more discussion with @jlewi in #234 For now the Fairing is kubefloe subpacakge, and user can install kubeflow-fairing by:
Ready for checking in, please view. thanks! |
Whoo Hooo! @jinchihe Can you open issues to update the examples and docs? They should probably be P0 and filed under project 0.7. I think we should probably get the xgboost_synthetic example updated at a minimum. You can remove the hold. I just wanted you to see this comment and file the issues. Thanks |
@jlewi Yes, already logged ticket in examples kubeflow/examples#636 and doc kubeflow/website#1146, and assigned to me, will update very soon. /hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinchihe, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Make fairing as a subpackage in kubeflow, see more in #234
After the PR, fairing will be a subpackage in kubeflow. and the changes are as following:
from kubeflow import fairing
andimport kubeflow.fairing
.For the kubeflow python sdk, user can install by
Which issue(s) this PR fixes:
Fixes #234
Special notes for your reviewer:
Release note:
This change is