New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update fairing to kubeflow-fairing #1155
update fairing to kubeflow-fairing #1155
Conversation
Reviewed the |
/assign @joeliedtke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change requested, otherwise this looks good to me.
40eac16
to
9d9b6e8
Compare
9d9b6e8
to
ac74b72
Compare
@joeliedtke Addressed your comments, and reviewed the |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joeliedtke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since the fairing has been a subpackage of kubeflow, renamed to kubeflow-fairing, see more in the PR kubeflow/fairing#359 and ticket kubeflow/fairing#234. And kubeflow-fairing 0.6.0 version has been released.
The PR is to update fairing to kubeflow-fairing, thanks.
Fixes: #1146
This change is