Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request ci-viewer.members.txt permission #221

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Request ci-viewer.members.txt permission #221

merged 1 commit into from
Mar 16, 2020

Conversation

Bobgy
Copy link
Contributor

@Bobgy Bobgy commented Mar 16, 2020 •
edited by jlewi
Loading

I need this permission for debugging kubeflow/kfctl#131 (comment). There are no error messages and the workflow just times out.

This change is Reviewable

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 16, 2020

/assign @jlewi

abhi-g
abhi-g reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

@abhi-g abhi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ff3bf1a into kubeflow:master Mar 16, 2020
@Bobgy Bobgy deleted the patch-2 branch March 16, 2020 23:48
@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 16, 2020

Thanks @abhi-g

@Bobgy
Copy link
Contributor Author

Bobgy commented Mar 17, 2020

Hi @abhi-g, @jlewi, I still cannot access kubeflow-ci or kubeflow-ci-deployment projects on GCP. Do you know if I missed any step besides this.

@Bobgy Bobgy mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-g abhi-g abhi-g left review comments

@richardsliu richardsliu Awaiting requested review from richardsliu

Assignees

@jlewi jlewi

@abhi-g abhi-g

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bobgy @k8s-ci-robot @abhi-g @jlewi