Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recreate the Experiments Parallel Coordinates Graph #1879

Closed
elenzio9 opened this issue May 31, 2022 · 1 comment
Closed

Recreate the Experiments Parallel Coordinates Graph #1879

elenzio9 opened this issue May 31, 2022 · 1 comment
Labels
kind/feature

Comments

@elenzio9
Copy link
Contributor

/kind feature

Currently, the code for that graph is unmaintainable and the corresponding script is more than 2000 lines of code, which does not allow us to reuse any of its logic for anything similar.

image

After some discussion with @kimwnasptd we decided to rework this part of the code using ECharts, which has a variety of charts and a clear documentation on how to use them. Our goal is to mimic the existing graph as much as possible.

Here is a prototype image of how it will look like:

image

Love this feature? Give it a 👍 We prioritize the features with the most 👍
@kimwnasptd kimwnasptd mentioned this issue Jun 2, 2022
Open
elenzio9 added a commit to arrikto/katib that referenced this issue Oct 19, 2022
@elenzio9
UI: Import echarts and ngx-echarts (kubeflow#1879)
73dcc9d 
* Import echarts module and ngx-echarts directive for Echarts.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/katib that referenced this issue Oct 19, 2022
@elenzio9
UI: Remove trials graph component (kubeflow#1879)
6e3afa5 
* Remove trials graph component.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/katib that referenced this issue Oct 19, 2022
@elenzio9
UI: Introduce graph's component (kubeflow#1879)
c5ab5f7 
* Create a new component that uses Echarts Parallel Graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/katib that referenced this issue Oct 19, 2022
@elenzio9
UI: Modify graph's wrapper component (kubeflow#1879)
577adb5 
* Make the wrapper component use the new graph.
* Show the graph when at least one trial is completed.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/katib that referenced this issue Oct 19, 2022
@elenzio9
UI: Parallel Graph unit test (kubeflow#1879)
6f541aa 
* Create unit test for Parallel Graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 mentioned this issue Oct 19, 2022
Merged
elenzio9 added a commit to arrikto/katib that referenced this issue Oct 21, 2022
@elenzio9
UI: Modify graph's wrapper component (kubeflow#1879)
76e0e2d 
* Make the wrapper component use the new graph.
* Show the graph when at least one trial is completed.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/katib that referenced this issue Oct 21, 2022
@elenzio9
UI: Parallel Graph unit test (kubeflow#1879)
c305464 
* Create unit test for Parallel Graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>
google-oss-prow bot pushed a commit that referenced this issue Oct 21, 2022
@elenzio9
Recreate the Experiments Parallel Coordinates Graph (#1974)
38e2017 
* UI: Import echarts and ngx-echarts (#1879)

* Import echarts module and ngx-echarts directive for Echarts.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* UI: Remove trials graph component (#1879)

* Remove trials graph component.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* UI: Introduce graph's component (#1879)

* Create a new component that uses Echarts Parallel Graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* UI: Modify graph's wrapper component (#1879)

* Make the wrapper component use the new graph.
* Show the graph when at least one trial is completed.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* UI: Parallel Graph unit test (#1879)

* Create unit test for Parallel Graph.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
@johnugeorge
Copy link
Member

Fixed by #1974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnugeorge @elenzio9