Recreate the Experiments Parallel Coordinates Graph #1974
Conversation
* Import echarts module and ngx-echarts directive for Echarts. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Remove trials graph component. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Create a new component that uses Echarts Parallel Graph. Signed-off-by: Elena Zioga <elena@arrikto.com>
|
Curious why CI tests haven't run |
|
/ok-to-test |
GitHub seems to have incidents with API requests. |
|
@kimwnasptd Could you help us review this PR? /assign @kimwnasptd |
There was a problem hiding this comment.
@tenzen-y @johnugeorge aside form a small nit the changes look good to me.
We've worked together with @elenzio9 for this one and I have already done an internal pass at this.
Next steps will be to fix all the unit tests and have a basic GH Action that will be running these tests with each PR. We've already done some ground work for the common code kubeflow/kubeflow#6676 and will continue with a subsequent PR
/lgtm
/approve
| @@ -253,4 +253,10 @@ export class ExperimentDetailsComponent implements OnInit, OnDestroy { | |||
| return StatusEnum.CREATED; | |||
| } | |||
| } | |||
|
|
|||
| private showGraphF(response: string): boolean { | |||
There was a problem hiding this comment.
Nit, let's use a slightly more descriptive name here. Should this be shoGraphFn instead?
There was a problem hiding this comment.
Yes, sure! I fixed it! Let me know if it works for you!
|
/hold EDIT: Added the LGTM and APPROVE labels by mistake |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Make the wrapper component use the new graph. * Show the graph when at least one trial is completed. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Create unit test for Parallel Graph. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
katib-recreate-experiments-graph
branch
from
6f541aa
to
c305464
Compare
|
/lgtm |
In this PR:
Refs #1879
Signed-off-by: Elena Zioga elena@arrikto.com