-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom CRD: Add primary pod labels #1305
Custom CRD: Add primary pod labels #1305
Conversation
9179667
to
3e93a0d
Compare
/retest |
@@ -207,6 +207,9 @@ type TrialTemplate struct { | |||
|
|||
// List of parameters that are used in trial template | |||
TrialParameters []TrialParameterSpec `json:"trialParameters,omitempty"` | |||
|
|||
// Labels that determines if pod needs to be injected by Katib sidecar container | |||
PrimaryPodLabels map[string]string `json:"primaryPodLabels,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for TFJob, user has to explicitly add primary labels ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User should specify it only in Experiment.
In TFJob for master pod, tfjob-controller automatically adds master label.
As I said before we can set default values for PrimaryPodLabels
for Kubeflow operators (TFJob, MPIJob).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/lgtm |
Related: #1214.
I named API:
PrimaryPodLabels
instead ofPrimaryPodLabel
because user can set more than 1 label there.PrimaryPodLabels
defines labels that mutated Pod must have.I didn't remove
isMasterRole
to not brake current test examples.Later we can update all examples with new APIs and remove redundant code.
Also I generated codegens and SDK.
/assign @gaocegege @johnugeorge @sperlingxx