Custom CRD: Add primary pod labels #1305
Conversation
|
This change is |
andreyvelich
force-pushed
the
issue-1214-primary-pod-label
branch
from
9179667
to
3e93a0d
Compare
|
/retest |
| @@ -207,6 +207,9 @@ type TrialTemplate struct { | |||
|
|
|||
| // List of parameters that are used in trial template | |||
| TrialParameters []TrialParameterSpec `json:"trialParameters,omitempty"` | |||
|
|
|||
| // Labels that determines if pod needs to be injected by Katib sidecar container | |||
| PrimaryPodLabels map[string]string `json:"primaryPodLabels,omitempty"` | |||
There was a problem hiding this comment.
So for TFJob, user has to explicitly add primary labels ?
There was a problem hiding this comment.
User should specify it only in Experiment.
In TFJob for master pod, tfjob-controller automatically adds master label.
As I said before we can set default values for PrimaryPodLabels for Kubeflow operators (TFJob, MPIJob).
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/lgtm |
Related: #1214.
I named API:
PrimaryPodLabelsinstead ofPrimaryPodLabelbecause user can set more than 1 label there.PrimaryPodLabelsdefines labels that mutated Pod must have.I didn't remove
isMasterRoleto not brake current test examples.Later we can update all examples with new APIs and remove redundant code.
Also I generated codegens and SDK.
/assign @gaocegege @johnugeorge @sperlingxx