Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tekton Pipeline example #1339

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

andreyvelich
Copy link
Member

This is example of using Tekton Pipeline in Katib Trial template. Blocked by: #1333.

I am currently having problems with Argo support, because of that: #1214 (comment).

In any case, I think Tekton should also work well in addition to Argo Workflows (#1081).

/assign @gaocegege @johnugeorge
/cc @czheng94 @nielsmeima @terrykong

@k8s-ci-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: terrykong, czheng94, nielsmeima.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This is example of using Tekton Pipeline in Katib Trial template. Blocked by: #1333.

I am currently having problems with Argo support, because of that: #1214 (comment).

In any case, I think Tekton should also work well in addition to Argo Workflows (#1081).

/assign @gaocegege @johnugeorge
/cc @czheng94 @nielsmeima @terrykong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich andreyvelich changed the title [WIP] Add Tekton Pipeline example Add Tekton Pipeline example Oct 14, 2020
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andreyvelich
Copy link
Member Author

/retest

@aws-kf-ci-bot
Copy link
Contributor

aws-kf-ci-bot commented Oct 23, 2020

@andreyvelich: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-katib-presubmit 57acfe2 link /test kubeflow-katib-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andreyvelich
Copy link
Member Author

I removed workflows from prow_config to unblock couple of Katib PRs.
@gaocegege @johnugeorge Do we want to merge them ?
Or we want to wait until kubernetes/test-infra#19657 PR will be merged and GCP prow for Katib will be disabled.

/cc @PatrickXYS @Jeffwan

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [andreyvelich,gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3a7f45e into kubeflow:master Oct 27, 2020
@andreyvelich andreyvelich deleted the add-tekton-example branch October 3, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants