Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump path-parse from 1.0.6 to 1.0.7 in /pkg/new-ui/v1beta1/frontend #1618

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 13, 2021

Bumps path-parse from 1.0.6 to 1.0.7.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 13, 2021
@aws-kf-ci-bot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/assign @kimwnasptd

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, dependabot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

@kimwnasptd I tried to build Katib UI image with this change and I was unable to create Experiment. So I am not sure if we want to make this update.

Getting these errors when I click on the different creation Steps:

main-es2015.1586f813bce9e54d6033.js:2 ERROR TypeError: Cannot read property 'controls' of undefined
    at Object.updateDirectives (main-es2015.1586f813bce9e54d6033.js:2)
    at Object.updateDirectives (main-es2015.1586f813bce9e54d6033.js:2)
    at ho (main-es2015.1586f813bce9e54d6033.js:2)
    at wo (main-es2015.1586f813bce9e54d6033.js:2)
    at _o (main-es2015.1586f813bce9e54d6033.js:2)
    at ho (main-es2015.1586f813bce9e54d6033.js:2)
    at wo (main-es2015.1586f813bce9e54d6033.js:2)
    at _o (main-es2015.1586f813bce9e54d6033.js:2)
    at ho (main-es2015.1586f813bce9e54d6033.js:2)
    at wo (main-es2015.1586f813bce9e54d6033.js:2)
    ```
    
  

@kimwnasptd
Copy link
Member

Thanks for the heads up! Looking into it

@kimwnasptd
Copy link
Member

@andreyvelich I checked out this PR and build the UI locally but was not able to reproduce this.

Could you create a distinct issue so we can debug there? Maybe you performed a list of steps that results in breaking the app, which is interesting to investigate.

Also did you observe this behavior only from the code of this PR?

@andreyvelich
Copy link
Member

Also did you observe this behavior only from the code of this PR?

Actually, I am getting this error even from the master branch.
Let me create an issue.

@andreyvelich
Copy link
Member

/retest

@andreyvelich
Copy link
Member

/lgtm

@andreyvelich
Copy link
Member

/retest

@google-oss-robot google-oss-robot merged commit f722725 into master Aug 13, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/pkg/new-ui/v1beta1/frontend/path-parse-1.0.7 branch August 13, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code lgtm ok-to-test size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants