Remove Charmed Operators for Katib #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the Charmed Operators for Katib, as well as the associated tests. In the past this repo was the source of truth for these operators, but they have since been maintained [here](https://github.com/canonical/katib-operators/) and we've done a poor job of keeping the repos in sync. This commit removes the redundancy.
google-oss-prow
bot
requested review from
anencore94,
DomFleischmann and
tenzen-y
andreyvelich
reviewed
Jun 7, 2023
There was a problem hiding this comment.
Thank you for the update @ca-scribner!
I think, it makes sense to add Katib Charmed GitHub link to the installation docs: https://www.kubeflow.org/docs/components/katib/hyperparameter/#installing-katib
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, ca-scribner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ca-scribner Thank you for addressing my suggestion! |
|
@tenzen-y welcome! Sorry it took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the Charmed Operators for Katib, as well as the associated tests.
In the past kubeflow/katib was the source of truth for these operators, but they have since been maintained here and we've done a poor job of keeping the repos in sync.
Reviewers, I think I've found everything but please let me know if I missed something that should also be removed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2072
Checklist: