Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding master pod check for default metric collector #300

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Adding master pod check for default metric collector #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions pkg/manager/metricscollector/meticscollector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (

apiv1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/client-go/kubernetes"
restclient "k8s.io/client-go/rest"

Expand Down Expand Up @@ -36,15 +37,17 @@ func NewMetricsCollector() (*MetricsCollector, error) {
}

func (d *MetricsCollector) CollectWorkerLog(wID string, wkind string, objectiveValueName string, metrics []string, namespace string) (*api.MetricsLogSet, error) {
var labelName string
labelMap := make(map[string]string)
if wkind == studyjob.TFJobWorker {
labelName = "tf_job_name"
labelMap["tf_job_name"] = wID
labelMap["tf_job_role"] = "master"
} else if wkind == studyjob.PyTorchJobWorker {
labelName = "pytorch_job_name"
labelMap["pytorch_job_name"] = wID
labelMap["pytorch_job_role"] = "master"
} else {
labelName = "job-name"
labelMap["job-name"] = wID
}
pl, _ := d.clientset.CoreV1().Pods(namespace).List(metav1.ListOptions{LabelSelector: labelName + "=" + wID, IncludeUninitialized: true})
pl, _ := d.clientset.CoreV1().Pods(namespace).List(metav1.ListOptions{LabelSelector: labels.Set(labelMap).String(), IncludeUninitialized: true})
if len(pl.Items) == 0 {
return nil, errors.New(fmt.Sprintf("No Pods are found in Job %v", wID))
}
Expand Down