Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Fix the describe link 'not foud' error. #9

Merged
merged 1 commit into from Aug 18, 2019

Conversation

xauthulei
Copy link
Member

@xauthulei xauthulei commented Aug 16, 2019

When execute the CMD: kfctl generate all -V

INFO[0000] Writing stripped KfDef to /root/llhu/mykube/app.yaml  filename="v1alpha1/application_types.go:626"
INFO[0000] Downloading /root/llhu/mykube/app.yaml to /tmp/557907718/app.yaml  filename="v1alpha1/application_types.go:334"
INFO[0000] 
****************************************************************
Notice anonymous usage reporting enabled using spartakus
To disable it
If you have already deployed it run the following commands:
  cd $(pwd)
  ks delete default -c spartakus
  kubectl -n ${K8S_NAMESPACE} delete deploy -l app=spartakus

Then run the following command to remove it from your ksonnet app:
  ks component rm spartakus

For more info: https://www.kubeflow.org/docs/guides/usage-reporting/```
****************************************************************

The above link 'For more info' can't be fond.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kubeflow/kfctl/9)
<!-- Reviewable:end -->

@k8s-ci-robot
Copy link
Contributor

Hi @xauthulei. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xauthulei
Copy link
Member Author

/cc @jinchihe ,Could you review this

@jlewi
Copy link
Contributor

jlewi commented Aug 16, 2019

/ok-to-test
/assign @jlewi

Thanks @xauthulei

Could you actually delete the line

ks delete default -c spartakus
  • We no longer use ksonnet so that line is outdated

Related to #3605

@xauthulei
Copy link
Member Author

@jlewi , I have removed it, please review that again. Thanks for your efforts here.

@xauthulei
Copy link
Member Author

* We no longer use ksonnet so that line is outdated

@jlewi , i found that we also need to remove

Then run the following command to remove it from your ksonnet app:
  ks component rm spartakus

Am I right ?

@jlewi
Copy link
Contributor

jlewi commented Aug 16, 2019

You are correct ; we need to remove all references to ks

@xauthulei
Copy link
Member Author

You are correct ; we need to remove all references to ks

@jlewi , I have removed that. please review that.

@jlewi
Copy link
Contributor

jlewi commented Aug 18, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 31d9c7a into kubeflow:master Aug 18, 2019
@jlewi
Copy link
Contributor

jlewi commented Aug 18, 2019

@xauthulei Can you cherry pick this onto kubeflow/kubeflow? We are still developing kfctl in kubeflow/kubeflow (see #7)

Right now we periodically copy all the changes from kubeflow/kubeflow to kubeflow/kfctl. So your changes will get overwritten unless you commit this on kubeflow/kubeflow

Sorry I missed this during my review; I didn't think to check what repo this was in.

@xauthulei
Copy link
Member Author

@jlewi, I will do it in kubeflow, Thanks again for your great efforts here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants