Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated usage report message in kfctl with kustomize #3605

Closed
IronPan opened this issue Jul 3, 2019 · 8 comments
Closed

Outdated usage report message in kfctl with kustomize #3605

IronPan opened this issue Jul 3, 2019 · 8 comments

Comments

@IronPan
Copy link
Member

IronPan commented Jul 3, 2019

Saw following error message when running

kfctl generate all -V --zone ${ZONE}

Building kfctl from head(https://github.com/kubeflow/kubeflow/tree/31a9bb666a13e3aea60f9a246574db27f2ee9d05) which uses kustomize.


Notice anonymous usage reporting enabled using spartakus
To disable it
If you have already deployed it run the following commands:
cd $(pwd)
ks delete default -c spartakus
kubectl -n ${K8S_NAMESPACE} delete deploy -l app=spartakus

Then run the following command to remove it from your ksonnet app:
ks component rm spartakus

For more info: https://www.kubeflow.org/docs/guides/usage-reporting/


@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor

jlewi commented Aug 18, 2019

@xauthulei committed kubeflow/kfctl#9

However, kubeflow/kubeflow is still source of truth for kfctl; so we need to get that PR cherry-picked onto kubeflow/kubeflow so the changes don't get overwritten on the next sync of kubeflow/kubeflow to kubeflow/kfctl

/assign @xauthulei

@k8s-ci-robot
Copy link
Contributor

@jlewi: GitHub didn't allow me to assign the following users: xauthulei.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

@xauthulei committed kubeflow/kfctl#9

However, kubeflow/kubeflow is still source of truth for kfctl; so we need to get that PR cherry-picked onto kubeflow/kubeflow so the changes don't get overwritten on the next sync of kubeflow/kubeflow to kubeflow/kfctl

/assign @xauthulei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xauthulei
Copy link
Member

@jlewi , I commit my fixes in PR #3941

@jlewi
Copy link
Contributor

jlewi commented Aug 19, 2019

@xauthulei Thank you so much.
Just one more thing. After #3941 is merged can you follow these instructions to cherry-pick it onto the v0.6-branch.

Its just a simple script you have to run to auto-create a PR with the same changes.

@xauthulei
Copy link
Member

@jlewi , I will try to do it later. Thanks.

@xauthulei
Copy link
Member

@xauthulei Thank you so much.
Just one more thing. After #3941 is merged can you follow these instructions to cherry-pick it onto the v0.6-branch.

Its just a simple script you have to run to auto-create a PR with the same changes.

It is done , see PR #3942, Could you review that. Many Thanks.

@jlewi
Copy link
Contributor

jlewi commented Aug 20, 2019

#3941 has been merged so I'm closing this out.

@jlewi jlewi closed this as completed Aug 20, 2019
Needs Triage automation moved this from To Do to Closed Aug 20, 2019
@jlewi jlewi removed this from Closed in Needs Triage Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.6.0
  
New
Development

No branches or pull requests

4 participants