Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update v2 deployment and ci tests #1380

Merged
merged 7 commits into from Oct 18, 2023

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Oct 16, 2023

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Oct 17, 2023
@Tomcli
Copy link
Member Author

Tomcli commented Oct 18, 2023

/assign @rimolive

I moved the development of kfptask and exit handler custom task to master branch. I will be moving the driver controller to external soon which will complete the issue #1361

@google-oss-prow
Copy link

@Tomcli: GitHub didn't allow me to assign the following users: rimolive.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @rimolive

I moved the development of kfptask and exit handler custom task to master branch. I will be moving the driver controller to external soon which will complete the issue #1361

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Tomcli Tomcli added the lgtm label Oct 18, 2023
@google-oss-prow google-oss-prow bot merged commit 5ac8032 into kubeflow:v2-integration Oct 18, 2023
4 checks passed
@Tomcli Tomcli deleted the v2-branch branch October 18, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant