-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tekton-compiler): Add env vars in kfp-driver to parametrize Object storage host and port #1378
feat(Tekton-compiler): Add env vars in kfp-driver to parametrize Object storage host and port #1378
Conversation
@rimolive since you changed the compiled Tekton yaml output, you also need to update the Tekton test cases over here in order to pass the unit tests. This is part of the unit test over here https://github.com/kubeflow/kfp-tekton/blob/v2-integration/backend/src/v2/compiler/tektoncompiler/tekton_test.go#L90 |
backend/src/v2/compiler/tektoncompiler/testdata/hello_world.yaml
Outdated
Show resolved
Hide resolved
backend/src/v2/compiler/tektoncompiler/testdata/mnist_pipeline.yaml
Outdated
Show resolved
Hide resolved
backend/src/v2/compiler/tektoncompiler/testdata/nestedloop.yaml
Outdated
Show resolved
Hide resolved
/retest |
/approve I need to double check the license on some of the images. Tekton 0.50.2 just released today with our regression and security fixes so we are going to update the Tekton client and licenses. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rimolive, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The github ci needs to be updated with the new examples in kfp 2.0.2. I have a PR to address it. |
I double checked the images and seems like just github action wasn't stable on pulling go package license names. On IBM Cloud our CI is more stable and able to build all the images without any problem. |
#1380 addressed the ci issue and I moved some image builds to the master branch because some image builds were reaching github rate limiting issues when checking licenses. |
/lgtm |
…ct storage host and port (kubeflow#1378) Co-authored-by: Tommy Li <Tommy.chaoping.li@ibm.com>
Which issue is resolved by this Pull Request:
N/A
Description of your changes:
In our multi-stack architecture for Kubeflow Pipelines, we need the kfp-driver to support parametrization of the MLMD location.
Environment tested:
python --version
): Python 3.10.12tkn version
): N/Akubectl version
): v1.25.2/etc/os-release
): Fedora 37Checklist: