Check for python module pyyaml when using kfctl.sh on platform GCP. (#…

…1975)
kubeflow · Nov 20, 2018 · 25dabab · 25dabab
1 parent 4240dfd
commit 25dabab
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/scripts/kfctl.sh b/scripts/kfctl.sh
@@ -293,7 +293,9 @@ main() {
   check_install ks
   check_install kubectl
 
-  source "${ENV_FILE}"
+  if [ "${PLATFORM}" == "gcp" ]; then
+    checkInstallPy pyyaml yaml
+  fi
 
   if [ "${COMMAND}" == "generate" ]; then
     if [ "${WHAT}" == "platform" ] || [ "${WHAT}" == "all" ]; then

diff --git a/scripts/util.sh b/scripts/util.sh
@@ -22,6 +22,16 @@ check_install() {
   fi
 }
 
+checkInstallPy() {
+  local PYPI=$1
+  local MOD=$2
+  if python -c "import pkgutil; exit(pkgutil.find_loader('${MOD}'))" &>/dev/null; then
+    echo "Failed to import python module ${MOD}."
+    echo "You don't have ${PYPI} installed. Please install ${PYPI}."
+    exit 1
+  fi
+}
+
 check_variable() {
   if [[ -z "${1}" ]]; then
     echo "'${2}' environment variable is not set. Please set it using export ${2}=value."