Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for python module pyyaml when using kfctl.sh on platform GCP. #1975

Merged
merged 1 commit into from Nov 20, 2018

Conversation

IMBurbank
Copy link
Contributor

@IMBurbank IMBurbank commented Nov 20, 2018

Fixes #1739.
Stems from discussion in #1898.

Add check to kfctl.sh for platform GCP to ensure python module pyyaml is present before function updateDM calls iam_patch.py and imports yaml.

Script ends exit 1 if module not present.

Also removed a duplicate source ${ENV_FILE}.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @IMBurbank. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Nov 20, 2018

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Nov 20, 2018

This is great thank you so much.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 25dabab into kubeflow:master Nov 20, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants