Skip to content

Commit

Permalink
add 'schedulerName' to openmpi package.
Browse files Browse the repository at this point in the history
In Kubernetes default scheduler, scheduling multiple openmpi package will sometimes lead deadlocks as discussed kubeflow/training-operator#165 .

In that case,  user would want to perform gang-scheduling(scheduling a group of pods all-together).  Currently, kube-arbitrator support it.

To achieve that, we need to make 'schedulerName' customizable.
  • Loading branch information
everpeace committed Apr 19, 2018
1 parent 8ea7688 commit 8305dcd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions kubeflow/openmpi/prototypes/openmpi.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// @param secret string Name of secret containing ssh keys.
// @optionalParam namespace string null Namespace to use for the components. It is automatically inherited from the environment if not set.
// @optionalParam workers number 4 Number of workers.
// @optionalParam schedulerName string default-scheduler scheduler name to use for the components.

local k = import "k.libsonnet";
local openmpi = import "kubeflow/openmpi/all.libsonnet";
Expand Down
2 changes: 1 addition & 1 deletion kubeflow/openmpi/workloads.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
restartPolicy: "Always",
terminationGracePeriodSeconds: 30,
dnsPolicy: "ClusterFirst",
schedulerName: "default-scheduler",
schedulerName: params.schedulerName,
volumes: [
{
name: "kubeflow-openmpi-secrets",
Expand Down

0 comments on commit 8305dcd

Please sign in to comment.