move admission webhook to gcp (#2781)

* update * fix
kubeflow · Mar 27, 2019 · ae10dc9 · ae10dc9
1 parent acb03c1
commit ae10dc9
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 34 deletions.
diff --git a/bootstrap/config/kfctl_basic_auth.yaml b/bootstrap/config/kfctl_basic_auth.yaml
@@ -30,6 +30,7 @@ components:
   - centraldashboard
   - cert-manager
   - cloud-endpoints
+  - gcp-credentials-admission-webhook
   - gpu-driver
   - jupyter-web-app
   - katib

diff --git a/bootstrap/config/kfctl_iap.yaml b/bootstrap/config/kfctl_iap.yaml
@@ -28,6 +28,7 @@ components:
   - centraldashboard
   - cert-manager
   - cloud-endpoints
+  - gcp-credentials-admission-webhook
   - gpu-driver
   - iap-ingress
   - jupyter-web-app

diff --git a/components/gcp-admission-webhook/README.md b/components/gcp-admission-webhook/README.md
@@ -56,3 +56,5 @@ If yes, it will add volume, volumeMount, and environment variable to the pod.
 1. https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/
 1. https://github.com/kubernetes/kubernetes/tree/v1.13.0/test/images/webhook
 1. https://github.com/morvencao/kube-mutating-webhook-tutorial
+1. How to self sign: [link](https://github.com/kubernetes/kubectl/issues/86)
+1. What to put for caBundle: [issue](https://github.com/kubernetes/kubernetes/issues/61171)
diff --git a/kubeflow/credentials-admission-webhook/README.md b/kubeflow/credentials-admission-webhook/README.md
diff --git a/kubeflow/credentials-admission-webhook/parts.yaml b/kubeflow/credentials-admission-webhook/parts.yaml
diff --git a/...redentials-admission-webhook/create_ca.sh → kubeflow/gcp/create_ca.sh b/...redentials-admission-webhook/create_ca.sh → kubeflow/gcp/create_ca.sh
diff --git a/...ission-webhook/prototypes/webhook.jsonnet → kubeflow/gcp/prototypes/webhook.jsonnet b/...ission-webhook/prototypes/webhook.jsonnet → kubeflow/gcp/prototypes/webhook.jsonnet
@@ -6,6 +6,6 @@
 // @optionalParam image string gcr.io/kubeflow-images-public/gcp-admission-webhook:v20190316-v0.4.0-rc.1-227-gac45af55-dirty-3f9236 The image for the webhook.
 // @optionalParam webhookSetupImage string gcr.io/kubeflow-images-public/ingress-setup:latest The image for setting up ingress.
 
-local webhook = import "kubeflow/credentials-admission-webhook/webhook.libsonnet";
+local webhook = import "kubeflow/gcp/webhook.libsonnet";
 local instance = webhook.new(env, params);
 instance.list(instance.all)
diff --git a/...tials-admission-webhook/webhook.libsonnet → kubeflow/gcp/webhook.libsonnet b/...tials-admission-webhook/webhook.libsonnet → kubeflow/gcp/webhook.libsonnet