Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move admission webhook to gcp #2781

Merged
merged 7 commits into from Mar 27, 2019
Merged

move admission webhook to gcp #2781

merged 7 commits into from Mar 27, 2019

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Mar 22, 2019 •
edited by jlewi

also install by kfctl/bootstrap

#2641

/cc @kunmingg

This change is Reviewable

@kunmingg
Copy link
Contributor

/lgtm
/approve
You might need to rebase

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 22, 2019
@lluunn
Copy link
Contributor Author

lluunn commented Mar 23, 2019

/retest

1 similar comment
@lluunn
Copy link
Contributor Author

lluunn commented Mar 25, 2019

/retest

@lluunn
Copy link
Contributor Author

lluunn commented Mar 25, 2019

/retest

@lluunn lluunn closed this Mar 25, 2019
@lluunn lluunn reopened this Mar 25, 2019
@lluunn lluunn mentioned this pull request Mar 25, 2019
Closed
@lluunn
Copy link
Contributor Author

lluunn commented Mar 26, 2019

/retest

@lluunn
Copy link
Contributor Author

lluunn commented Mar 26, 2019

/retest

@lluunn lluunn mentioned this pull request Mar 26, 2019
Closed
@lluunn
Copy link
Contributor Author

lluunn commented Mar 26, 2019

/retest

3 similar comments
@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2019

/retest

@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2019

/retest

@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2019

/retest

@lluunn
Copy link
Contributor Author

lluunn commented Mar 27, 2019

failure in kfctl go to apply metacontroller:

 Component metacontroller apply failed; Error: find objects: RUNTIME ERROR: couldn't open import \"kubeflow/credentials-admission-webhook/webhook.libsonnet\": no match locally or in the Jsonnet library paths\n\t<extvar:__ksonnet/components>:56:19-84\tthunk <webhook> from <object <anonymous>>\n\t<extvar:__ksonnet/components>:57:20-27\tthunk <instance> from <object <anonymous>>\n\t<extvar:__ksonnet/components>:59:3-11\tobject <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:104:21-31\tthunk from <object <anonymous>>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:104:12-32\tobject <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:(99:32)-(110:13)\tfunction <anonymous>\n\t<std>:237:50-62\tfunction <anonymous>\n\t\t\n\t<std>:764:38-46\tthunk from <thunk from <function <aux>>>\n\t<std>:817:34-35\tfunction <anonymous>\n\t<std>:764:24-47\tthunk from <function <aux>>\n\t<std>:764:9-57\tfunction <aux>\n\t<std>:765:5-28\tfunction <anonymous>\n\t<std>:817:5-46\tfunction <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:206:20-75\tobject <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:207:70-76\tthunk from <object <anonymous>>\n\t<std>:773:22-25\tthunk from <function <anonymous>>\n\t<std>:773:13-26\tfunction <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:207:30-77\tobject <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:374:9-25\tthunk from <thunk from <object <anonymous>>>\n\t<std>:764:38-46\tthunk from <thunk from <function <aux>>>\n\t<std>:817:34-35\tfunction <anonymous>\n\t<std>:764:24-47\tthunk from <function <aux>>\n\t<std>:764:9-57\tfunction <aux>\n\t<std>:765:5-28\tfunction <anonymous>\n\t<std>:817:5-46\tfunction <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:(372:11)-(385:6)\tobject <anonymous>\n\t<extvar:__ksonnet/components>:15:19-31\tthunk from <object <anonymous>>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:387:36-39\tthunk from <function <anonymous>>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/common/util.libsonnet:206:34-37\tthunk from <function <anonymous>>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/lib/ksonnet-lib/v1.9.7/k.libsonnet:96:24-29\tthunk from <function <anonymous>>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/lib/ksonnet-lib/v1.9.7/k.libsonnet:97:36-41\tthunk from <function <anonymous>>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/lib/ksonnet-lib/v1.9.7/k.libsonnet:97:27-42\tfunction <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/lib/ksonnet-lib/v1.9.7/k.libsonnet:96:13-30\tfunction <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/common/util.libsonnet:206:15-39\tfunction <anonymous>\n\t/mnt/test-data-volume/kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0/kfctl-89a0/ks_app/vendor/kubeflow/application/application.libsonnet:387:26-40\tfunction <anonymous>\n\t<extvar:__ksonnet/components>:15:5-32\tobject <anonymous>\n\tDuring manifestation\t\n" filename="ksonnet/ksonnet.go:191"

https://pantheon.corp.google.com/logs/viewer?organizationId=714441643818&project=kubeflow-ci&minLogLevel=0&expandAll=false&timestamp=2019-03-27T19:39:38.002000000Z&customFacets=&limitCustomFacetWidth=true&dateRangeEnd=2019-03-27T19:39:49.834Z&interval=PT1H&resource=k8s_container&folder=&scrollTimestamp=2019-03-27T19:06:36.049123724Z&advancedFilter=resource.type%3D%22k8s_container%22%0Aresource.labels.pod_name%3D%22kubeflow-presubmit-kfctl-go-2781-9510fe2-8853-89a0-3367399205%22&dateRangeStart=2019-03-27T18:39:49.834Z

@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ae10dc9 into kubeflow:master Mar 27, 2019
lluunn added a commit to lluunn/kubeflow that referenced this pull request Mar 28, 2019
@lluunn
move admission webhook to gcp (kubeflow#2781)
4a8942b 
* update

* fix
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@lluunn @k8s-ci-robot
move admission webhook to gcp (kubeflow#2781)
99064fd 
* update

* fix
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
@lluunn @k8s-ci-robot
move admission webhook to gcp (kubeflow#2781)
d95321e 
* update

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunmingg kunmingg Awaiting requested review from kunmingg

Assignees

@kunmingg kunmingg

Labels
approved cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lluunn @kunmingg @k8s-ci-robot @googlebot