Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make downloading our ksonnet registry for getting started efficient #1154

Closed
jlewi opened this issue Jul 9, 2018 · 4 comments
Closed

Make downloading our ksonnet registry for getting started efficient #1154

jlewi opened this issue Jul 9, 2018 · 4 comments
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Jul 9, 2018

We'd like to avoid users running into GITHUB Api limits and needing to create a GitHub API token just to get started.

The current thinking is to clone the repo and then use the ability of ksonnet to use a local file as a registry.

This works but its slow because our registry is huge.

I don't think setting depth=1 will work because we will typically want to use a particular commit corresponding to a tagged release and this will not be the latest commit on a branch.

Some some suggestions here:
https://stackoverflow.com/questions/31278902/how-to-shallow-clone-a-specific-commit-with-depth-1

One solution would be to explicitly publish a tarball containing our registry so users could just download and unpack it.

@jlewi jlewi changed the title Efficiently clone release branch of ksonnet registry; publish tarball? Make downloading our ksonnet registry for getting started efficient Jul 9, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Jul 9, 2018

I think GitHub might provide a URL that makes it easy to download a particular commit as a zip file.
https://stackoverflow.com/questions/13636559/how-to-download-zip-from-github-for-a-particular-commit-sha

@jlewi
Copy link
Contributor Author

jlewi commented Jul 9, 2018

We can get stable links by tag just from the releases page.
https://github.com/kubeflow/kubeflow/releases

@jlewi
Copy link
Contributor Author

jlewi commented Jul 9, 2018

ksonnet/ksonnet#641 is tracking native support in ks for this.

@jlewi
Copy link
Contributor Author

jlewi commented Jul 9, 2018

/assign jlewi

jlewi added a commit to jlewi/kubeflow that referenced this issue Jul 11, 2018
* Download tarballs of the repo; this avoids GITHUB API token limits
  and is much faster because it avoids GitHistory

* Install most of the packages into the app so that the user won't
  have to do that step to start using other packages.

Fix kubeflow#1154
k8s-ci-robot pushed a commit that referenced this issue Jul 11, 2018
* Make the deploy scripts more efficient and other fixes.

* Download tarballs of the repo; this avoids GITHUB API token limits
  and is much faster because it avoids GitHistory

* Install most of the packages into the app so that the user won't
  have to do that step to start using other packages.

Fix #1154

* Enable anonymous usage collection.
jlewi added a commit to jlewi/kubeflow that referenced this issue Jul 11, 2018
* Make the deploy scripts more efficient and other fixes.

* Download tarballs of the repo; this avoids GITHUB API token limits
  and is much faster because it avoids GitHistory

* Install most of the packages into the app so that the user won't
  have to do that step to start using other packages.

Fix kubeflow#1154

* Enable anonymous usage collection.
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
* Make the deploy scripts more efficient and other fixes.

* Download tarballs of the repo; this avoids GITHUB API token limits
  and is much faster because it avoids GitHistory

* Install most of the packages into the app so that the user won't
  have to do that step to start using other packages.

Fix kubeflow#1154

* Enable anonymous usage collection.
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
* Build goptuna in CI

* Update prow

* Delete Image Pull Policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant