Make the deploy scripts more efficient and other fixes. #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Download tarballs of the repo; this avoids GITHUB API token limits and is much faster because it avoids GitHistory * Install most of the packages into the app so that the user won't have to do that step to start using other packages. Fix kubeflow#1154
|
/assign @ankushagarwal |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
test flake looks like an HTTP issue cloning the repo. |
|
Filed for the previous test flake /issues/1178 |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this pull request
Jul 11, 2018
* Make the deploy scripts more efficient and other fixes. * Download tarballs of the repo; this avoids GITHUB API token limits and is much faster because it avoids GitHistory * Install most of the packages into the app so that the user won't have to do that step to start using other packages. Fix kubeflow#1154 * Enable anonymous usage collection.
jlewi
added a commit
to jlewi/kubeflow
that referenced
this pull request
Jul 11, 2018
…anch. * This includes changes like kubeflow#1174 which makes downloading the repo efficient by downloading a tarball and not using git clone. * Also pull in the scripts for GKE that don't use bootstrapper.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Make the deploy scripts more efficient and other fixes. * Download tarballs of the repo; this avoids GITHUB API token limits and is much faster because it avoids GitHistory * Install most of the packages into the app so that the user won't have to do that step to start using other packages. Fix kubeflow#1154 * Enable anonymous usage collection.
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
* Related to kubeflow#1174. * This is a follow on to kubeflow#1175. kubeflow#1175 attempted to fix this issue but the unittest was insufficient because it didn't handle the case where there were multiple K8s resources in a file. * The test is updated to handle that case. We use a more powerful YAML processing library kyaml from kustomize. * Also remove empty annotations (GoogleCloudPlatform/kubeflow-distribution#16) because this triggers a bug in kpt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download tarballs of the repo; this avoids GITHUB API token limits
and is much faster because it avoids GitHistory
Install most of the packages into the app so that the user won't
have to do that step to start using other packages.
Move scripts/minikube/deploy.sh to scripts/deploy.sh - This script is generic and will work for any existing K8s cluster not just minikube.
Fix #1154
This change is