New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does CentralUi need ClusterScope? #1450
Comments
If Kubeflow components (Argo, job-operator, jupyter, Katib) are deployed to same namespace then CentralUI doesn't need ClusterScope. A namespaced scope should be good enough. |
/area 0.4.0 |
/remove-area 0.4.0 |
@swiftdiaries Until proven otherwise, I think we can assume central dashboard is in the same name space as the other components. So lets replace the cluster scoped role with a namespace scoped role. |
Sounds good 👍 Will get a PR in with the change.
…On Sun, Oct 7, 2018 at 20:05 Jeremy Lewi ***@***.***> wrote:
@swiftdiaries <https://github.com/swiftdiaries> Until proven otherwise, I
think we can assume central dashboard is in the same name space as the
other components.
So lets replace the cluster scoped role with a namespace scoped role.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1450 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV9Rn2-ZAWk2AR0CNRIXCwV9cxiNqiAiks5uisEMgaJpZM4WVRbQ>
.
|
/remove-priority p1 |
Closing because a PR has already been submitted and merged for this. |
@swiftdiaries: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* cert-manager namespace needs label control-plane * cert-manager namespace needs the control-plane label to prevent application of kfserving webhooks. related to: kubeflow#1450 * Fix error in YAML
See #1213
We'd like to be able to scope Kubeflow to a particular namespace to better support multi-tenant environments.
It looks like CentralUI is creating a ClusterRole right now. Do we need ClusterScope? Could we use a namespace scoped role?
/cc @swiftdiaries
The text was updated successfully, but these errors were encountered: