Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does CentralUi need ClusterScope? #1450

Closed
jlewi opened this issue Aug 31, 2018 · 8 comments
Closed

Does CentralUi need ClusterScope? #1450

jlewi opened this issue Aug 31, 2018 · 8 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Aug 31, 2018

See #1213

We'd like to be able to scope Kubeflow to a particular namespace to better support multi-tenant environments.

It looks like CentralUI is creating a ClusterRole right now. Do we need ClusterScope? Could we use a namespace scoped role?

/cc @swiftdiaries

@swiftdiaries
Copy link
Member

swiftdiaries commented Aug 31, 2018

If Kubeflow components (Argo, job-operator, jupyter, Katib) are deployed to same namespace then CentralUI doesn't need ClusterScope. A namespaced scope should be good enough.

@jbottum
Copy link
Contributor

jbottum commented Sep 30, 2018

/area 0.4.0

@jbottum
Copy link
Contributor

jbottum commented Sep 30, 2018

/remove-area 0.4.0

@jlewi
Copy link
Contributor Author

jlewi commented Oct 8, 2018

@swiftdiaries Until proven otherwise, I think we can assume central dashboard is in the same name space as the other components.

So lets replace the cluster scoped role with a namespace scoped role.

@swiftdiaries
Copy link
Member

swiftdiaries commented Oct 8, 2018 via email

@chrisheecho
Copy link

/remove-priority p1
/priority p0

@swiftdiaries
Copy link
Member

Closing because a PR has already been submitted and merged for this.
/close

@k8s-ci-robot
Copy link
Contributor

@swiftdiaries: Closing this issue.

In response to this:

Closing because a PR has already been submitted and merged for this.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrisheecho chrisheecho added this to To do in 0.4.0 Oct 30, 2018
@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
@jlewi jlewi moved this from To do to Done in 0.4.0 Nov 12, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
* cert-manager namespace needs label control-plane

* cert-manager namespace needs the control-plane label to prevent
  application of kfserving webhooks.

related to: kubeflow#1450

* Fix error in YAML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.4.0
  
Done
Development

No branches or pull requests

6 participants