Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change clusterrole to role #1728

Merged
merged 5 commits into from Oct 12, 2018
Merged

change clusterrole to role #1728

merged 5 commits into from Oct 12, 2018

Conversation

swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Oct 8, 2018 •
edited by jlewi

Addresses issue: #1450.
Assuming all kubeflow components are going to installed to a single namespace, CentralUI does not need cluster level scope. This PR is to restrict CentralUI's scope down to a single namespace.

This change is Reviewable

@swiftdiaries
Copy link
Member Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Oct 8, 2018

Would you mind adding some unittests as part of this PR to verify that the manifests are correct?
Here's an example
https://github.com/kubeflow/kubeflow/tree/master/kubeflow/core/tests

@k8s-ci-robot k8s-ci-robot added size/L and removed size/S labels Oct 9, 2018
@jlewi
Copy link
Contributor

jlewi commented Oct 11, 2018

Looks like you just need to format the jsonnet files.

@swiftdiaries
Copy link
Member Author

/retest

1 similar comment
@swiftdiaries
Copy link
Member Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Oct 12, 2018

Error:

RROR: (gcloud.deployment-manager.deployments.update) Error in Operation [operation-1539288437049-577f9847f46a9-3a71c660-bd6565af]: errors:
- code: RESOURCE_ERROR
 location: /deployments/kfctl-3393/resources/kfctl-3393
 message: '{"ResourceType":"container.v1.cluster","ResourceErrorCode":"400","ResourceErrorMessage":{"code":400,"message":"Master
   version \"1.10.7-gke.2\" is unsupported.","status":"INVALID_ARGUMENT","statusMessage":"Bad
   Request","requestPath":"https://container.googleapis.com/v1/projects/kubeflow-ci/zones/us-east1-d/clusters","httpMethod":"POST"}}'

This is fixed by #1747 please rebase and rerun the tests.

@swiftdiaries
Copy link
Member Author

Thanks 👍

@jlewi
Copy link
Contributor

jlewi commented Oct 12, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b7869d3 into kubeflow:master Oct 12, 2018
leoncamel pushed a commit to leoncamel/kubeflow that referenced this pull request Oct 14, 2018
@swiftdiaries @leoncamel
change clusterrole to role (kubeflow#1728)
9e2c7a6 
* change clusterrole to role

* add unit test for centralui

* run jsonnet fmt
@swiftdiaries swiftdiaries deleted the cuipermissions branch March 6, 2019 23:01
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@swiftdiaries @k8s-ci-robot
change clusterrole to role (kubeflow#1728)
6540daf 
* change clusterrole to role

* add unit test for centralui

* run jsonnet fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsliu richardsliu Awaiting requested review from richardsliu

@ScorpioCPH ScorpioCPH Awaiting requested review from ScorpioCPH

Assignees

@jlewi jlewi

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@swiftdiaries @jlewi @k8s-ci-robot @googlebot