Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.0-rc.1: ERROR no prototype names matched 'pytorch-operator' #1663

Closed
jlewi opened this issue Sep 29, 2018 · 4 comments
Closed

v0.3.0-rc.1: ERROR no prototype names matched 'pytorch-operator' #1663

jlewi opened this issue Sep 29, 2018 · 4 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Sep 29, 2018

I got the error

+ ks registry add kubeflow /home/jlewi/tmp/kubeflow_v0.3.0-rc-1//kubeflow
+ ks pkg install kubeflow/argo
INFO Retrieved 4 files                            
+ ks pkg install kubeflow/core
INFO Retrieved 37 files                           
+ ks pkg install kubeflow/examples
INFO Retrieved 7 files                            
+ ks pkg install kubeflow/katib
INFO Retrieved 7 files                            
+ ks pkg install kubeflow/mpi-job
INFO Retrieved 6 files                            
+ ks pkg install kubeflow/pytorch-job
INFO Retrieved 5 files                            
+ ks pkg install kubeflow/seldon
INFO Retrieved 16 files                           
+ ks pkg install kubeflow/tf-serving
INFO Retrieved 9 files   
+ ks generate pytorch-operator pytorch-operator
ERROR no prototype names matched 'pytorch-operator' 

when following the install guide

https://www.kubeflow.org/docs/started/getting-started-gke/

Related to #1541

@jlewi
Copy link
Contributor Author

jlewi commented Sep 29, 2018

It looks like my vendor directory isn't setup correctly.

.
├── components
├── environments
├── lib
│   └── v1.9.7
└── vendor
    └── kubeflow
        └── home
            └── jlewi
                └── tmp
                    └── kubeflow_v0.3.0-rc-1
                        └── kubeflow
                            ├── argo
                            │   └── prototypes
                            ├── core
                            │   ├── prototypes
                            │   └── tests
                            ├── examples
                            │   └── prototypes
                            ├── katib
                            │   └── prototypes
                            ├── mpi-job
                            │   └── prototypes
                            ├── pytorch-job
                            │   └── prototypes
                            ├── seldon
                            │   ├── json
                            │   └── prototypes
                            └── tf-serving
                                └── prototypes

@jlewi
Copy link
Contributor Author

jlewi commented Sep 29, 2018

Here's the command kfctl ran

INFO Successfully removed environment 'default'   
+ ks registry add kubeflow /home/jlewi/tmp/kubeflow_v0.3.0-rc-1//kubeflow

It looks like there is an extra "/" before the kubeflow dir and that causes the problem.

@jlewi
Copy link
Contributor Author

jlewi commented Sep 29, 2018

It looks like the problem is because I had a trailing slash on KUBEFLOW_REPO

echo ${KUBEFLOW_REPO}
/home/jlewi/tmp/kubeflow_v0.3.0-rc-1/

Looks like the code expects there not to be a trailing slash.

ks registry add kubeflow "${KUBEFLOW_REPO}/kubeflow"

jlewi added a commit to jlewi/kubeflow that referenced this issue Sep 29, 2018
* Parts of the script assume there is no trailing slash. So if we don't
  normalize things we have problems.

* Will need to cherry-pick this into v0.3

Related to kubeflow#1663
k8s-ci-robot pushed a commit that referenced this issue Sep 29, 2018
* Remove trailing slash from KUBEFLOW_REPO

* Parts of the script assume there is no trailing slash. So if we don't
  normalize things we have problems.

* Will need to cherry-pick this into v0.3

Related to #1663

* Add a comment.
@jbottum
Copy link
Contributor

jbottum commented Sep 30, 2018

/area 0.4.0

jlewi added a commit to jlewi/kubeflow that referenced this issue Oct 1, 2018
* Remove trailing slash from KUBEFLOW_REPO

* Parts of the script assume there is no trailing slash. So if we don't
  normalize things we have problems.

Related to kubeflow#1663
k8s-ci-robot pushed a commit that referenced this issue Oct 1, 2018
* Remove trailing slash from KUBEFLOW_REPO

* Parts of the script assume there is no trailing slash. So if we don't
  normalize things we have problems.

Related to #1663
@jlewi jlewi closed this as completed Oct 3, 2018
@carmine carmine added this to the 0.4.0 milestone Nov 6, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
* Remove trailing slash from KUBEFLOW_REPO

* Parts of the script assume there is no trailing slash. So if we don't
  normalize things we have problems.

* Will need to cherry-pick this into v0.3

Related to kubeflow#1663

* Add a comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants