Remove trailing slash from KUBEFLOW_REPO #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parts of the script assume there is no trailing slash. So if we don't normalize things we have problems. * Will need to cherry-pick this into v0.3 Related to kubeflow#1663
|
/assign @richardsliu |
|
/lgtm |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, swiftdiaries The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlewi
added a commit
to jlewi/kubeflow
that referenced
this pull request
Oct 1, 2018
* Remove trailing slash from KUBEFLOW_REPO * Parts of the script assume there is no trailing slash. So if we don't normalize things we have problems. Related to kubeflow#1663
k8s-ci-robot
pushed a commit
that referenced
this pull request
Oct 1, 2018
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Remove trailing slash from KUBEFLOW_REPO * Parts of the script assume there is no trailing slash. So if we don't normalize things we have problems. * Will need to cherry-pick this into v0.3 Related to kubeflow#1663 * Add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of the script assume there is no trailing slash. So if we don't
normalize things we have problems.
Will need to cherry-pick this into v0.3
Related to #1663
This change is