Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kfctl.sh apply platform assumes availability of yaml python library #1739

Closed
cwbeitel opened this issue Oct 9, 2018 · 3 comments
Closed

Comments

@cwbeitel
Copy link
Contributor

cwbeitel commented Oct 9, 2018

> ${KUBEFLOW_REPO}/scripts/kfctl.sh apply platform
...
Traceback (most recent call last):
  File "/Users/cb/deploy/kfctl/scripts/gke/iam_patch.py", line 17, in <module>
    import yaml
ImportError: No module named yaml

This was after running download.sh without setting KUBEFLOW_VERSION i.e. pulling from master.

@chrisheecho
Copy link

I ran into this as well. i tried pip install PyYAML as a way around it

@IMBurbank
Copy link
Contributor

If you're on gcp you can run

pip install pyyaml --user

@jlewi
Copy link
Contributor

jlewi commented Nov 16, 2018

I think the long term fix here is to replace kfctl.sh with a go binary #1419.

surajkota pushed a commit to surajkota/kubeflow that referenced this issue Jun 13, 2022
* Rename directory `admission-webhook' to `apps/admission-webhook/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `common/centraldashboard' to `apps/centraldashboard/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `jupyter/jupyter-web-app' to `apps/jupyter/jupyter-web-app/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `jupyter/notebook-controller' to `apps/jupyter/notebook-controller/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `katib' to `apps/katib/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `kfserving' to `apps/kfserving/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `kubebench' to `apps/kubebench/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `mpi-job' to `apps/mpi-job/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `mxnet-job' to `apps/mxnet-job/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `pipeline' to `apps/pipeline/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `profiles' to `apps/profiles/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `pytorch-job' to `apps/pytorch-job/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `tf-training' to `apps/tf-training/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `xgboost-job' to `apps/xgboost-job/upstream'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `cert-manager' to `common/cert-manager'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `dex-auth' to `common/dex-auth'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `istio' to `common/istio'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `istio-1-3-1' to `common/istio-1-3-1'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `knative' to `common/knative'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `kubeflow-roles' to `common/kubeflow-roles'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `namespaces' to `common/namespaces'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `application' to `contrib/application'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `argo' to `contrib/argo'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `tektoncd' to `contrib/tektoncd'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `default-install' to `contrib/default-install'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `common/spartakus' to `contrib/spartakus'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `common/basic-auth' to `contrib/basic-auth'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `experimental' to `contrib/experimental'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `metacontroller' to `contrib/metacontroller'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `gatekeeper' to `contrib/gatekeeper'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `seldon' to `contrib/seldon'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `spark' to `contrib/spark'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `modeldb' to `contrib/modeldb'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `metadata' to `contrib/metadata'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `flink' to `contrib/flink'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `aws' to `distributions/aws'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `gcp' to `distributions/gcp'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `kfdef' to `distributions/kfdef'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Rename directory `stacks' to `distributions/stacks'

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* docs: Update docs to reflect the new structure

Update the README to reflect the new folder structure of manifests. In
addition, move the obsolete information about kfctl manifests into its
own doc.

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* tests: Update unit tests for new structure

Update the unit tests for the new manifests structure. Temporarily
disable the autogenerated tests on stacks. Consider re-enabling them
before the 1.3 release. In addition, evaluate if we need the legacy
kustomizations tests. Perhaps a simpler sanity test of building
all kustomizations in the repo would be preferrable.

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants