Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python script to set parameters for ksonnet prototypes #322

Closed
jlewi opened this issue Mar 1, 2018 · 2 comments
Closed

Python script to set parameters for ksonnet prototypes #322

jlewi opened this issue Mar 1, 2018 · 2 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Mar 1, 2018

Background #215

As part of our release process, we need to update the prototypes for various ksonnet prototypes to set the parameters to the value of newly built values (e.g. the newly built image for the TFJob operator).

So we'd like a tool like

python -m kubeflow.kubeflow.releasing.update_prototype --file=.../all.jsonnet --values=tfJobImage=gcr.io/kubeflow/tf-operator:v20180301
@Maerville
Copy link
Contributor

Maerville commented Apr 17, 2018

Hi I would like to work on that issue, although I have few questions to ask.

So, basically, now I see 3 patterns of assigning value to the parameters:

default value:
// @optionalParam tfJobImage string gcr.io/tf-on-k8s-dogfood/tf_operator:v20180117-04425d9-dirty-e3b0c44 The image for the TfJob controller.

assign while creating parameter:
local tfJobImage = import "param://tfJobImage";

and also assign inner property
tfJobImage:: "gcr.io/kubeflow-images-staging/tf_operator:v20180226-403",

so, after running the script in a way you provided in example, which types of assignment have to be replaced?

@jlewi
Copy link
Contributor Author

jlewi commented Apr 18, 2018

Fantastic.

The first and third options that you mentioned.

Basically our release process is defined here. As the instructions note, after we build a bunch of images we need to update the ksonnet configs as part of a release. We'd like a script to do this so we can automate it.

yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Nov 1, 2019
* Update Seldon Kustomize

* update seldon tests

* update seldon test files

* update to 0.4.0 of seldon

* update tests and clean Makefile

* fix volume claim issue

* Put kustomize hack directly in statefulset
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants