New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a minimal release process for our ksonnet configs #215
Comments
https://github.com/skywinder/github-changelog-generator could generate changelog automatically. |
@willb Can I assign this to you for now since you are working on a proposal for the release process? |
We had another break #283 at head affecting serving. I need to push a new Docker image for TFJob to fix #322 I'm thinking as part of this we should start documenting the steps it takes to do a release and then use that to inform a proposal. I chatted briefly with @willb and it sounds like he's still researching various options. In brief here's what I think this will look like
I think we should start using the tag STABLE to refer to the most recent stable commit of our registry. |
We now have an E2E test for TFServing. When we release our ksonnet configs the flow will be something like
A simple thing to do would be to add another workflow which runs the E2E test for TFServing but without building a new image and without overriding the image used by the ksonnet component. /cc @lluunn |
Start putting instructions together for how one could release Kubeflow. The instructions are rather adhoc and reflect what one could do today They do not reflect what we think our release process should look like. The current instructions only cover building and releasing TFJob operator and the TFServing images Refactor the TFServing image E2E workflow so we can use it to build release images We want to run a different cluster in a different project for releases and publish to a different GCR registry We move the default parameters into the .libsonnet file; The number of parameters was getting large so I think it makes sense to pass them as a dictionary and not as a list of arguments Make buildTemplate a local variable so we automatically inherit the values of the parameters and don't have to pass a bunch of arguments every time we build it. Update the actual image used by TFSerivng to the newly built image. @willb and some others are putting together a proposal for our release process. Hopefully this PR will help inform that work and help us figure out how to iterate. Related to #215
To elaborate on the above I think we should have the following
|
There are some instructions here: I think the next steps would be
@willb Any chance you could take a stab at this? Preferably this week? |
@jlewi definitely assign this to me; I’m in offsite meetings all week but will be able to give this contiguous free time while traveling home or early next week. |
Thank you so much @willb. Consider it assigned. |
@willb Any update? Do you think we could cut an initial release this week with whatever's at head? |
Let me know where I can be of assistance … |
@jlewi I think so! I burned some time trying to set up a local sandbox environment but am going to bail on that for now. I'll ping you if I need help. |
/area 0.4.0 |
This has already been fixed for a while; closing this issue. |
* Add yliu989 to the org yuzhui liu has been contributing to KFServing * Update org.yaml * Update org.yaml
Kubeflow was broken for quite a bit because the ksonnet configs got out of sync with the Docker images.
To avoid this we should start pinning/tagging known good releases.
Context:
kubeflow/training-operator#339
Discussion in #208
If we create a tag or branch then we can just use that tag with ksonnet
At a minimum it would be good to start defining a process for creating releases to figure out what we will do for our 0.1 milestone.
Even better would be to think about how to automate the toil of releases e.g
- Running tests to qualify the release
- Publishing release notes
Are there existing tools we can use?
The text was updated successfully, but these errors were encountered: