Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish a pattern for creating/using secrets used by multiple kubeflow prototypes #372

Closed
elsonrodriguez opened this issue Mar 7, 2018 · 2 comments
Closed

Establish a pattern for creating/using secrets used by multiple kubeflow prototypes #372

elsonrodriguez opened this issue Mar 7, 2018 · 2 comments
Assignees
@aronchick

Comments

@elsonrodriguez
Copy link
Contributor

#323 has secret handling semantics that may need to be forked out if more Kubeflow prototypes end up using those s3 credentials.

Consolidating such logic in a single place to avoid duplication is a good idea. Otherwise every other prototype will end up with very similar parameters for s3 or any other credentials/config that need to be added.
@elsonrodriguez elsonrodriguez mentioned this issue Mar 7, 2018
Merged
@jlewi jlewi mentioned this issue Mar 26, 2018
Closed
@jlewi
Copy link
Contributor

jlewi commented Apr 2, 2018

/assign @aronchick

@jlewi
Copy link
Contributor

jlewi commented Jun 11, 2018

I think the path forwarded is using pod presets or admission controllers. #782 created a prototype for doing that.

Closing this issue for that reason.

@jlewi jlewi closed this as completed Jun 11, 2018
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
@jlewi
Move the K8s manifests for github sync into internal-acls. (kubeflow#372
03a6bfd 
)

* This localizes the code in a single place which will make them
  easier to find and maintain going forward.

Fix kubeflow#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aronchick aronchick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aronchick @elsonrodriguez @jlewi