Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vim's .swp files from git #249

Merged
merged 6 commits into from Feb 16, 2018
Merged

Remove vim's .swp files from git #249

merged 6 commits into from Feb 16, 2018

Conversation

inc0
Copy link

@inc0 inc0 commented Feb 15, 2018

just a small gitignore tweak


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @inc0. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jlewi jlewi merged commit 0cc0540 into kubeflow:master Feb 16, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
)

* This localizes the code in a single place which will make them
  easier to find and maintain going forward.

Fix kubeflow#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants