Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Central UI is working #805

Closed
lluunn opened this issue May 14, 2018 · 9 comments
Closed

Verify Central UI is working #805

lluunn opened this issue May 14, 2018 · 9 comments
Assignees
@jlewi
Labels
area/front-end area/0.2.0

Comments

@lluunn
Copy link
Contributor

lluunn commented May 14, 2018

No description provided.

@jlewi
Copy link
Contributor

jlewi commented May 15, 2018

/assign @jlewi

I tested it out and there are a couple issues

#808 - There is a strange box that says "nothing to display here"
There is no link to JupyterHub

The central UI doesn't work with IAP because the proxy before Ambassador is mapping "/" to JupyterHub.

Will open individual issues for these issues.

@jlewi jlewi closed this as completed May 15, 2018
@jlewi jlewi mentioned this issue May 15, 2018
Closed
@jlewi jlewi reopened this May 15, 2018
@jlewi
Copy link
Contributor

jlewi commented May 15, 2018

Lets leave this issue open until all the fixes are submitted and verified.

@jlewi jlewi mentioned this issue May 15, 2018
Closed
@jlewi
Copy link
Contributor

jlewi commented May 15, 2018

#239 We need Ambassador to map /hub to /hub and (maybe /user to /user) so that central-ui can redirect to JupyterHub.

@jlewi
Copy link
Contributor

jlewi commented May 15, 2018

#810 add link to JupyterHub.

@jlewi
Copy link
Contributor

jlewi commented Jun 11, 2018

I tested it out and the central box is fixed

But there is a problem #957 with the central UI not rendering if the screen is too small.

@jlewi
Copy link
Contributor

jlewi commented Jun 18, 2018

All the bugs appear to be fixed.
Need to build an image from head and then update the core component to pin the image.

jlewi added a commit to jlewi/kubeflow that referenced this issue Jun 18, 2018
@jlewi
Pin the central UI image.
8d85349 
* Expose central UI image as a parameter.

* We want to pin the central UI image to a particular version so that updates
  to latest don't break users.

Related to kubeflow#805
@jlewi jlewi mentioned this issue Jun 18, 2018
Merged
k8s-ci-robot pushed a commit that referenced this issue Jun 18, 2018
@jlewi @k8s-ci-robot
Pin the central UI image. (#1019)
8b609f6 
* Pin the central UI image.

* Expose central UI image as a parameter.

* We want to pin the central UI image to a particular version so that updates
  to latest don't break users.

Related to #805

* Fix centraldasbhoard_test
@jlewi
Copy link
Contributor

jlewi commented Jun 20, 2018

HEAD is updated. Waiting on the next RC to verify this.

@swiftdiaries
Copy link
Member

swiftdiaries commented Jun 20, 2018 via email

@jlewi
Copy link
Contributor

jlewi commented Jun 20, 2018

I verified this using configs @ HEAD which are using image
gcr.io/kubeflow-images-public/centraldashboard:v20180618-v0.2.0-rc.0-5-g715aafc8-e3b0c4

Marking this as fixed.

@jlewi jlewi closed this as completed Jun 20, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this issue Feb 11, 2021
@jlewi @k8s-ci-robot
Pin the central UI image. (kubeflow#1019)
9ad1420 
* Pin the central UI image.

* Expose central UI image as a parameter.

* We want to pin the central UI image to a particular version so that updates
  to latest don't break users.

Related to kubeflow#805

* Fix centraldasbhoard_test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlewi jlewi

Labels
area/front-end area/0.2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @swiftdiaries @lluunn